Fix layout validation #5015
Merged
Fix layout validation #5015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes KhronosGroup#5010 * Unless scalar block layout is enabled, no member can reside at an offset between the end of the previous member that is a struct or array and the next multiple of that alignment
dneto0
previously approved these changes
Dec 16, 2022
source/val/validate_decorations.cpp
Outdated
| @@ -547,6 +547,8 @@ spv_result_t checkLayout(uint32_t struct_id, const char* storage_class_str, | |||
| hasImproperStraddle(id, offset, constraint, constraints, vstate)) | |||
| return fail(memberIdx) | |||
| << "is an improperly straddling vector at offset " << offset; | |||
| if (ordered_member_idx > 0) { | |||
There was a problem hiding this comment.
This does nothing.
Please remove.
| (spv::Op::OpTypeArray == opcode || spv::Op::OpTypeStruct == opcode)) { | ||
| // Uniform block rules don't permit anything in the padding of a struct | ||
| // or array. | ||
| // Non-scalar block layout rules don't permit anything in the padding of |
There was a problem hiding this comment.
Yep, that's what the spec says.
dneto0
approved these changes
Dec 16, 2022
|
CI-windows-msvc-2015-release-bazel has been failing consistently for unrelated reasons. #5022 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5010