Require C++11 *or later* #5020
Merged
Require C++11 *or later* #5020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow externally setting CMAKE_CXX_STANDARD to 14, for example, which is needed to build protobufs
alan-baker
approved these changes
Dec 15, 2022
SpaceIm
reviewed
Feb 2, 2023
Comment on lines
+36
to
+41
| if(NOT CMAKE_CXX_STANDARD) | ||
| set(CMAKE_CXX_STANDARD 11) | ||
| endif() | ||
| if(${CMAKE_CXX_STANDARD} LESS 11) | ||
| message(FATAL_ERROR "SPIRV-Tools requires C++11 or later, but is configured for C++${CMAKE_CXX_STANDARD})") | ||
| endif() |
There was a problem hiding this comment.
All targets should just have target_compile_features(<target> PUBLIC cxx_std_11), CMakeLists of libraries should never set CMAKE_CXX_STANDARD.
There was a problem hiding this comment.
Question: Should CMAKE_CXX_STANDARD be set when building executables?
E.g. the command line tools are built via https://github.com/KhronosGroup/SPIRV-Tools/blob/main/tools/CMakeLists.txt
There was a problem hiding this comment.
I'm confused. Why does CMAKE_CXX_STANDARD exist, then? Or is it legacy?
Ah, target_compile_features is new in CMake 3.8.
https://cmake.org/cmake/help/latest/release/3.8.html?highlight=cxx_std_11#c-c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow externally setting CMAKE_CXX_STANDARD to 14, for example, which is needed to build protobufs