Validate decoration of structs with RuntimeArray #5094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
FoggyMist
force-pushed
the
glslang/2439
branch
from
c7e1e09 to
5c0479d
Compare
Partially fixes KhronosGroup/glslang#2439 * When OpTypeStruct is used in Vulkan env and its last member is a RuntimeArray, check if the struct is decorated with Block or BufferBlock, as required by VUID-...-04680.
FoggyMist
force-pushed
the
glslang/2439
branch
from
5c0479d to
0d75f96
Compare
FoggyMist
force-pushed
the
glslang/2439
branch
from
ded3be7 to
a544fe2
Compare
|
Sorry, I forgot to run formatter. |
alan-baker
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes KhronosGroup/glslang#2439