Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SPV_KHR_float_controls2 #5543

Merged
merged 8 commits into from
Jan 25, 2024
Merged

Add support for SPV_KHR_float_controls2 #5543

merged 8 commits into from
Jan 25, 2024

Conversation

alan-baker
Copy link
Contributor

Depends on KhronosGroup/SPIRV-Headers#408. I will update deps after it is merged.

Adds support for:

  • validation
  • parsing assembly

cc @gnl21

@alan-baker alan-baker requested a review from dneto0 January 24, 2024 20:37
dneto0
dneto0 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the DEPS update to pick up the headers change.
LGTM!

@gnl21
Copy link
Contributor

gnl21 commented Jan 25, 2024

LGTM. Thanks.

@alan-baker alan-baker force-pushed the dneto-spv-khr-float-controls2 branch from 8aaed3d to c5fd74c Compare January 25, 2024 14:45
@alan-baker alan-baker enabled auto-merge (squash) January 25, 2024 15:20
@alan-baker alan-baker merged commit ef2f432 into KhronosGroup:main Jan 25, 2024
24 checks passed
@alan-baker alan-baker deleted the dneto-spv-khr-float-controls2 branch January 25, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dneto0 dneto0 dneto0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alan-baker @gnl21 @dneto0