Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spirv-dis: add decorations to comments #5675

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

ShabbyX
Copy link
Contributor

@ShabbyX ShabbyX commented May 18, 2024

No description provided.

@ShabbyX ShabbyX force-pushed the more-comments branch 2 times, most recently from dd2bc9a to 799e0c7 Compare May 18, 2024 02:58
@ShabbyX ShabbyX requested a review from s-perron May 31, 2024 19:16
Copy link
Collaborator

@s-perron s-perron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more tests. Otherwise looks reasonable.

source/disassemble.h Outdated Show resolved Hide resolved
test/binary_to_text_test.cpp Outdated Show resolved Hide resolved
@ShabbyX ShabbyX force-pushed the more-comments branch 3 times, most recently from e1534ac to 769e5eb Compare June 10, 2024 18:11
@s-perron s-perron merged commit c3178da into KhronosGroup:main Jun 10, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants