spirv-val, core: add support for OpExtInstWithForwardRefs #5698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds validation and support for OpExtInstWithForwardRefs. This new instruction will be used for non-semantic debug info, when forward references are required. For now, this commit only fixes the code to handle this new instruction, and adds validation rules. But it does not add the pass to generate/fix the OpExtInst instruction when forward references are in use. Such pass would be useful for DXC or other tools, but I wanted to land validation rules first. This commit also bumps SPIRV-Headers to get this new opcode. Signed-off-by: Nathan Gauër <brioche@google.com>
Keenuts
changed the title
s-perron
reviewed
Jun 3, 2024
There was a problem hiding this comment.
Some of the changes in the folding rules should be reverted. Some instructions like FMix and FClamp should not have forward references, so I don't think you should change checks specifically related to those, and other like them.
Alan or someone else should look at the validator code.
alan-baker
requested changes
Jun 3, 2024
Signed-off-by: Nathan Gauër <brioche@google.com>
alan-baker
approved these changes
Jun 4, 2024
s-perron
approved these changes
Jun 4, 2024
jkwak-work
added a commit
to shader-slang/SPIRV-Tools
that referenced
this pull request
Jul 2, 2024
Merging '6a2bdee' from http://github.com/KhronosGroup/SPIRV-Tools.git This merge is required to address an issue KhronosGroup#4304. > commit 6a2bdee > Author: Nathan Gauër <brioche@google.com> > Date: Tue Jun 4 16:18:06 2024 +0200 > spirv-val, core: add support for OpExtInstWithForwardRefs (KhronosGroup#5698)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds validation and support for
OpExtInstWithForwardRefs. This new instruction will be used for non-semantic debug info, when forward references are required.
For now, this commit only fixes the code to handle this new instruction, and adds validation rules. But it does not add the pass to generate/fix the OpExtInst instruction when forward references are in use. Such pass would be useful for DXC or other tools, but I wanted to land validation rules first.
This commit also bumps SPIRV-Headers to get this new opcode.