Add minor fixes to accessor/multi_ptr wording #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add restriction for accessor::get_multi_ptr that it's only available when AccessTarget is target::device as it can't be used in a host task. * Change alias used in multi_ptr legacy specialization as value_type is not defined.
This was referenced Jul 4, 2023
* Introduce value_type instead of using ElementType. * Add get_raw/get_decorated to void/legacy specialization.
Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
gmlueck
reviewed
Jul 6, 2023
There was a problem hiding this comment.
A couple of comments below. In addition, this statement in the PR description seems confusing:
It also changes the alias used in
multi_ptr::get_rawin thedecorated::legacyspecialization toElementTypeasvalue_typeis not defined.
Because this PR adds the definition of value_type.
AerialMantis
commented
Jul 6, 2023
gmlueck
approved these changes
Jul 6, 2023
keryell
approved these changes
Jul 12, 2023
|
LGTM |
keryell
added a commit
that referenced
this pull request
Sep 10, 2024
Add minor fixes to accessor/multi_ptr wording. Some minor issues were raised in #432 after the PR was merged, so this is a follow-up PR to address those. This PR adds a restriction for accessor::get_multi_ptr that it's only available when AccessTarget is target::device as it can't be used in a host task. It adds the value_type alias to the decorated::legacy specialization of multi_ptr and adds the get_raw and get_decorated member functions to the void/decorated::legacy specializations of multi_ptr. It also changes the alias used in multi_ptr::get_raw in the decorated::legacy specialization to ElementType as value_type is not defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor issues were raised in #432 after the PR was merged, so this is a follow-up PR to address those.
This PR adds a restriction for
accessor::get_multi_ptrthat it's only available whenAccessTargetistarget::deviceas it can't be used in a host task.It adds the
value_typealias to thedecorated::legacyspecialization ofmulti_ptrand adds theget_rawandget_decoratedmember functions to thevoid/decorated::legacyspecializations ofmulti_ptr.It also changes the alias used in
multi_ptr::get_rawin thedecorated::legacyspecialization toElementTypeasvalue_typeis not defined.cc @gmlueck @steffenlarsen