Fix defs of "fast_length" and "fast_normalize" #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmlueck
force-pushed
the
gmlueck/gentype-funcs-v2
branch
from
b07970b
to
4437aa9
Compare
It appears that these function definitions were incorrectly transcribed from OpenCL. In OpenCL, they rely on the half-precision versions of `sqrt` and `rsqrt`, not the overloads that take `half` types. Closes internal issue 656.
gmlueck
force-pushed
the
gmlueck/fast-uses-half-precision
branch
from
98dbf7c
to
a0a03c7
Compare
keryell
reviewed
Aug 10, 2023
Co-authored-by: Ronan Keryell <ronan@keryell.fr>
Co-authored-by: Ronan Keryell <ronan@keryell.fr>
AerialMantis
approved these changes
Aug 23, 2023
gmlueck
changed the base branch from
gmlueck/gentype-funcs-v2
to
SYCL-2020/master
|
Ready to merge. |
keryell
pushed a commit
that referenced
this pull request
Sep 10, 2024
Fix defs of "fast_length" and "fast_normalize"
gmlueck
added a commit
that referenced
this pull request
Nov 7, 2024
Fix defs of "fast_length" and "fast_normalize" (cherry picked from commit e63b8b7)
gmlueck
added a commit
that referenced
this pull request
Nov 7, 2024
Fix defs of "fast_length" and "fast_normalize" (cherry picked from commit e63b8b7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that these function definitions were incorrectly transcribed from OpenCL. In OpenCL, they rely on the half-precision versions of
sqrtandrsqrt, not the overloads that takehalftypes.Closes internal issue 656.