Remove confusing wording about errors #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this while reviewing work on the SYCL reference guide. The specification for the member functions `queue::get_context` and `queue::get_device` implied that they could throw an exception for an error scenario. I cannot think of any reason these functions could fail because a queue always has a context and a device. Therefore, I think we should remove these sentences. For example, notice that there is no similar wording for `queue::is_in_order`, which also has no obvious reason to fail.
|
I guess there is always the possibility that the device is no longer available for some reason. |
But we have already decided that SYCL 2020 does not support hot-swapped devices:
(https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#sec:device-class) |
|
I agree with Greg that for SYCL 2020, I don't see how they can fail. (for SYCL SC Next this is another topic :) ) |
TApplencourt
approved these changes
Oct 11, 2023
keryell
approved these changes
Oct 31, 2023
keryell
pushed a commit
that referenced
this pull request
Sep 10, 2024
Remove confusing wording about errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while reviewing work on the SYCL reference guide.
The specification for the member functions
queue::get_contextandqueue::get_deviceimplied that they could throw an exception for an error scenario. I cannot think of any reason these functions could fail because a queue always has a context and a device. Therefore, I think we should remove these sentences. For example, notice that there is no similar wording forqueue::is_in_order, which also has no obvious reason to fail.