Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflow: break lines at end of sentence / 80 cols #495

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

TApplencourt
Copy link
Contributor

@TApplencourt TApplencourt commented Nov 10, 2023

Follow up of #481 Rebase from master ( 463a26c )

@TApplencourt TApplencourt mentioned this pull request Nov 10, 2023
Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I verified the following:

  • The generated PDF has no unexpected differences vs. the main branch. (The only differences are the date and commit ID on the title page.)
  • The script changes in this PR are identical to those in Run reflow #481, which were already reviewed.

@gmlueck gmlueck changed the title Run Reflow, rebased from master Reflow aciidoc, break lines at end of sentence and at 80 columns Nov 13, 2023
@gmlueck gmlueck changed the title Reflow aciidoc, break lines at end of sentence and at 80 columns Reflow: break lines at end of sentence / 80 cols Nov 13, 2023
@gmlueck
Copy link
Contributor

gmlueck commented Nov 13, 2023

Merging as editorial

@gmlueck gmlueck merged commit e859ef7 into SYCL-2020/master Nov 13, 2023
3 checks passed
@TApplencourt TApplencourt deleted the reflow2 branch November 13, 2023 16:51
@@ -0,0 +1,7 @@
#!/usr/bin/python3 -i
#
# Copyright (c) 2018-2019 Collabora, Ltd.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright 2023 The Khronos Group Inc.?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that seems weird since the implementation of the Python package is copyright Khronos. I created a new __init__.py file in #558.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,454 @@
#!/usr/bin/python3 -i
#
# Copyright 2013-2023 The Khronos Group Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2013-2023 -> just 2023?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that @TApplencourt started by copying the "conventions.py" file from the Vulkan repo, which has this copyright date range. Since this file is a derived work, I think it's correct to keep the original date range.

keryell pushed a commit that referenced this pull request Sep 10, 2024
Run Reflow, rebased from master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants