layers: Remove Stub from dispatch table helper #8318
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 223324. |
|
CI Vulkan-ValidationLayers build # 17113 running. |
spencer-lunarg
changed the title
|
CI Vulkan-ValidationLayers build # 17113 failed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-stub
branch
from
498cd80
to
be5320b
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 226603. |
|
CI Vulkan-ValidationLayers build # 17160 running. |
|
CI Vulkan-ValidationLayers build # 17160 failed. |
|
Is it a draft? |
|
Making a draft now seems that this fails on Android (due to the Android Loader setup) and need to go do some git digging to understand why these Stub functions were added and if/how we can actually remove them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Want to see if these
Stubcalls are neededCurrently they are the source of hidding a nasty bug (#7562) when we call dispatch internally with the wrong version of the API
It might be better to hide the invalid function with a null call