Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Bone Dir default value TEMPERANCE to BLENDER #1777

Closed

Conversation

TokageItLab
Copy link

@TokageItLab TokageItLab commented Oct 25, 2022

Fixes #1662

As explained there, Bone Dir should keep the original glTF bone orientations by default, so it should use BLENDER. The behavior of not using heuristics by default is same as other importers such as fbx, collada, etc.

I also wrote a slightly more detailed description in ToolTip. I'm not sure if the enum name BLENDER is appropriate to begin with, but we can leave that alone for now.

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2022

CLA assistant check
All committers have signed the CLA.

@julienduroure
Copy link
Collaborator

Don't think there is some consensus yet on the "better" default we should have.
So I will close this PR. I don't want to have conversations on both side. Let's continue the discussion on #1662 directly.

I also will have a talk with Blender devs and Khronos Working Group team, to have a feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import: Temperance should be off by default
3 participants