Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XmpMetadataRoundedCube.glb metadata #150

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

hybridherbst
Copy link
Contributor

Fixes #149. The new glb file contains the same metadata as the gltf (plus glTF-Transform v4.0.8 as generator).

@javagl
Copy link
Contributor

javagl commented Oct 23, 2024

*looks left*
*looks right*
Why are you hesitating?

However, I dragged the GLB into gltf.report, and it displays the metadata (of which, in its details, I have to assume that it is correct). So I'll just merge that one...

@javagl javagl merged commit 517a5db into KhronosGroup:main Oct 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XmpMetadataRoundedCube glTF-binary does not contain any metadata
2 participants