Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The OPD equation may be incorrect in KHR_materials_iridescence spec README.md #2212

Closed
emadurandal opened this issue Oct 8, 2022 · 0 comments
Closed

The OPD equation may be incorrect in KHR_materials_iridescence spec README.md #2212

emadurandal opened this issue Oct 8, 2022 · 0 comments

Comments

@emadurandal
Copy link
Contributor

Hi, I am trying to implement KHR_materials_iridescence in my library.

The current formula for OPD in the latest main branch (https://github.com/KhronosGroup/glTF/tree/2a9996a2ea66ab712590eaf62f39f1115996f5a3/extensions/2.0/Khronos/KHR_materials_iridescence) is as follows

OPD = 2.0 * iridescenceIor * iridescenceThickness * cosTheta1;

However, looking at the original paper, this cosTheta1 should be cosTheta2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lexaknyazev @emadurandal