Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iridescence math #2367

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Fix iridescence math #2367

merged 2 commits into from
Mar 15, 2024

Conversation

bsdorra
Copy link
Contributor

@bsdorra bsdorra commented Mar 12, 2024

This PR fixes two issues:

  1. Math rendering seems to be broken because of missing 'githubusercontent' images. I replaced the the images with actual latex math.
  2. Use correct cosine for optical path difference calculation as reported in The OPD equation may be incorrect in KHR_materials_iridescence spec README.md #2212

@lexaknyazev lexaknyazev merged commit 760aff5 into KhronosGroup:main Mar 15, 2024
1 check passed
@bsdorra bsdorra deleted the fix_iridescence_math branch March 18, 2024 11:13
abbaswasim pushed a commit to abbaswasim/glTF that referenced this pull request Sep 7, 2024
@bsdorra @abbaswasim
KHR_materials_iridescence: Fix math (KhronosGroup#2367)
a23de71 
* Replace invalid image tags with latex math
* Fix cosine in optical path difference calculation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexaknyazev lexaknyazev lexaknyazev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsdorra @lexaknyazev