Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KHR_environment_map #1956

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

KHR_environment_map #1956

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
a2dbf75
Initial commit for environment light extension
rsahlin Mar 16, 2021
5e7ec02
Update schema
rsahlin Mar 16, 2021
e44c245
Simplify by using KTX2 for cubemaps
rsahlin Mar 16, 2021
2b2a174
Remove rotation and update to use specularCubemaps
rsahlin Mar 16, 2021
0370801
Add KTX2 float formats
rsahlin Mar 16, 2021
c2df7bb
Clarify use of other KHR extensions
rsahlin Mar 17, 2021
6612a00
Updates according to review comments
rsahlin Apr 7, 2021
3b3e9be
Updated wording related to KTX
rsahlin Apr 8, 2021
905350a
Updates, reference KHR_texture_ktx
rsahlin Apr 9, 2021
0df13f2
Update to open issues
rsahlin Apr 9, 2021
fdc5e5b
Clarification for cubemap filtering
rsahlin Apr 30, 2021
20d55ca
Clarification for cubemap filtering
rsahlin Apr 30, 2021
70653fe
Remove resolved issues
rsahlin May 20, 2021
0f553ce
Updated light properties
rsahlin May 26, 2021
4706330
Update specularCubemap description
rsahlin May 26, 2021
3744d7e
Moved `lights` into extension
rsahlin May 26, 2021
71d8f3a
Updates to use local cubemap, clarifications
rsahlin Oct 15, 2021
73b3133
Add bbox min/max, use luminance and texture ref
rsahlin Oct 15, 2021
6f2b3fc
Remove KHR_texture ktx extension
rsahlin Oct 18, 2021
904937b
Add KHR_texture_ktx to textures array
rsahlin Oct 18, 2021
a596a69
Clarification of light contribution
rsahlin Oct 21, 2021
d2ffe33
Remove luminance factor
rsahlin Oct 21, 2021
a8c21ec
Remove luminance from schema
rsahlin Oct 21, 2021
3232a99
Add contributor
rsahlin Oct 21, 2021
00b3730
Clarification of pre-filtered maps, add references
rsahlin Oct 22, 2021
590c2ac
Remove dependency to KHR_texture_ktx
rsahlin Dec 8, 2021
bdbd58d
Schema update
rsahlin Dec 13, 2021
0b849a7
Rename extension to KHR_environment_map
rsahlin Jun 14, 2023
c6241f9
Update README.md
rsahlin Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions extensions/2.0/Khronos/KHR_lights_environment/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@
Draft

Open issues:
Should Spherical Harmonics be supported or should clients be forced to evaluate the specular cubemap for diffuse contribution.
The question comes down to if resolution supplied by 9 coefficients SH is enough for most usecases?
Since the SH are optional, and I believe the quality using 9 coefficients is reasonable, I am leaning towards keeping them.
Should Spherical Harmonics be supported or should clients be forced to evaluate the specular cubemap for diffuse contribution?
The question comes down to if resolution supplied by 9 coefficients SH is enough for most usecases?
It could also be the case that a scene only wants diffuse contribution.
rsahlin marked this conversation as resolved.
Show resolved Hide resolved
A link to an implementation that uses the cubemap for specular, diffuse and reflection would be beneficial.
rsahlin marked this conversation as resolved.
Show resolved Hide resolved

If compressed texture format is used how should pre-filtering for roughness reflection be done?
rsahlin marked this conversation as resolved.
Show resolved Hide resolved
May lead to unpredicted results of clients shall decode then create mip-levels since the result will likely take much more GPU memory since compression is likely not supported on target.
Expand Down