glTF 0.8 #320
glTF 0.8 #320
Conversation
| "title" : "accessor", | ||
| "type" : "object", | ||
| "description" : "A typed accessor into a buffer-view. WebGL: see vertexAttribPointer().", | ||
| "extends" : { "$ref" : "glTFChildOfRootProperty.schema.json" }, |
There was a problem hiding this comment.
accessor is more generic than vertexAttribPointer
There was a problem hiding this comment.
Yeap, I plan on breaking these "WebGL" comments out into a separate custom schema property for "Related WebGL Concepts and APIs." (auto-generated spec from schema). I think these are related enough that we should keep this.
There was a problem hiding this comment.
In a separate custom schema as you suggest yes. For now I will remove the reference to vertexAttribPointer.
|
@pjcozzi that's it for my first pass on reviewing. it's a huge amount of work here, thanks a lot Patrick for having put this together. based on your feedback I can iterate on this and push something tomorrow evening and merge at once. |
|
Will comment on this tonight or tomorrow morning as SIGGRAPH allows. :) |
|
@fabrobinet please update and merge when ready. Sorry, I have limited time to make changes here at SIGGRAPH. |
|
Thanks @pjcozzi I will manage to update and merge this tonight |
If you removed this in 0.8, the converter is now broke because it will still be there. |
|
@pjcozzi actually I didn't remember interpolation was actually exported and you're right so I have reverted this change. |
@fabrobinet for your immediate review.
CC #241