Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Google Test as the testing framework #189

Closed
antiagainst opened this issue Mar 4, 2016 · 4 comments
Closed

Use Google Test as the testing framework #189

antiagainst opened this issue Mar 4, 2016 · 4 comments

Comments

@antiagainst
Copy link
Contributor

The existing test harness is a home-made shell script. All the tests and the expected results are written as plain text files in an integrated test style. This is not quite easy to maintain and slow to run.

@antiagainst
Copy link
Contributor Author

Add I'll take on this.

@yavn
Copy link

yavn commented Mar 4, 2016

I agree things could be improved. At the moment it's quite cumbersome to fix the failing tests after a code change. There's no easy way to find which test failed first, no way to re-run it. I usually use some ad-hoc shell script to do just this.

Are you proposing to replace diff tests with some new C++ unit tests, or just use Google Test as a test runner?

@antiagainst
Copy link
Contributor Author

@yavn: No, not only as a "test runner". The ideal outcome would be to rewrite all existing tests using the gtest framework, and I'll work towards that.

On the other side, introducing gtest will make sure all future tests are written in a much clearer way.

@antiagainst
Copy link
Contributor Author

Done via #190.

qingyuanzNV pushed a commit to qingyuanzNV/glslang that referenced this issue Oct 18, 2022
…mic_float_min_max

Add header changes for SPV_EXT_shader_atomic_float_min_max
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants