Fix printing of 'unknown stage' during crossStageCheck #3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a 'stage' field to symbol nodes to remember what stage a symbol was defined in. Previously, 'unknown' stage was printed because linker object symbols are merged into a TIntermediate with language=EShLangCount while cross stage rules are checked. Storing the stage in the symbol fixes this problem.
rj123-nv
commented
Oct 16, 2024
| @@ -59,10 +60,12 @@ namespace glslang { | |||
| void TIntermediate::error(TInfoSink& infoSink, const char* message, EShLanguage unitStage) | |||
There was a problem hiding this comment.
This could be changed to accept another "stage" argument, but that would require changing a bunch of callers which I opted not to do.
If getStage() is EShLangCount, as in the case of the intermediate created for merging linker objects, just opt to only print "unitStage"
|
@arcady-lunarg can you please help review? |
arcady-lunarg
approved these changes
Nov 11, 2024
|
Thanks for reviewing. I rebased the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a 'stage' field to symbol nodes to remember what stage a symbol was
defined in.
Previously, 'unknown' stage was printed because linker object symbols are
merged into a TIntermediate with language=EShLangCount while cross stage
rules are checked. Storing the stage in the symbol fixes this problem.
Fixes errors such as
WARNING: Linking unknown stage and fragment stages: Matched shader interfaces are using different instance names.
unknown stage stage: Block: crossStageBlock2 Instance: blockName1: ""
fragment stage: Block: crossStageBlock2 Instance: blockName2: ""