HLSL: Add min*{float,int,uint} types #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Today, we need to map |
ghost
changed the title
|
Changed to relaxed precision float32 for min float types, removed WIP. |
johnkslang
requested changes
Oct 29, 2016
| break; | ||
|
|
||
| case EHTokMin10float: | ||
| new(&type) TType(min10float_bt, EvqTemporary, EpqLow); // equiv to Medium when generating SPIR-V: |
There was a problem hiding this comment.
Did you verify that lowp is sufficient for min10?
(It may be irrelevant if this is only for SPIR-V, but then, if that's the case mediump would work everywhere without needing to know if lowp is okay.)
These HLSL types are guaranteed to have at least the given number of bits, but may have more.
min{16,10}float is mapped to EbtFloat at medium precision -> SPIRV RelaxedPrecision
min{16,12}int and min16uint are mapped to mediump -> SPIR-V RelaxedPrecision
|
I didn't find an explicit precision for lowp (nor mediump, except for how it maps to the SPIR-V RelaxedPrecision decoration). I changed the PR to use mediump for safety, for all the new types. |
johnkslang
approved these changes
Nov 1, 2016
ghost
mentioned this pull request
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These HLSL types are guaranteed to have at least the given number of bits, but may have more.
min{16,10}float is mapped to EbtFloat16 with medium precision -> SPIR-V RelaxedPrecision.
min{16,12}int and min16uint are mapped to mediump -> SPIR-V RelaxedPrecision