Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add Footprint support of USR USR-C322. #1154

Merged
merged 1 commit into from
Apr 11, 2019

Conversation

cybertale
Copy link
Contributor

@cybertale cybertale commented Dec 8, 2018

Signed-off-by: Song Qiang songqiang1304521@gmail.com

Add Footprint Support of USR USR-C322, which is a 3Mbps low power UART-WIFI Module.


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing

https://www.usriot.com/download/WIFI/USR-C322-Hardware-Manual_V1.2.01.pdf

  • An example screenshot image is very helpful

usr-mod

  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate

KiCad/kicad-symbols#1236

  • Check the output of the Travis automated check scripts - fix any errors as required

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@DanSGiesbrecht DanSGiesbrecht added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Dec 10, 2018
@myfreescalewebpage myfreescalewebpage self-assigned this Jan 10, 2019
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Jan 10, 2019
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Jan 10, 2019

Hi @cybertale , thanks for contributing,

A few comments I have during my review:

  • Can you move the device to "RF_WiFi" library (that's a new one in which we have all WiFi modules). If you haven it, it's because you need to solve branch conflict before by merging the master in your branch.
  • I do not agree with fab layer dimensions, module is 18.22x26.65mm, not 18.62x26.54mm (distance between pins 28 and 29 is not correct).
  • It is possible to make a better keepout area design hatched diagonally, see example at http://kicad-pcb.org/libraries/klc/F4.5/

Please can you fix above before I can continue the review ? Thanks.

Cheers,
Joel

@myfreescalewebpage
Copy link
Collaborator

Hi @cybertale are you still alive on this subject ? Thanks

@cybertale
Copy link
Contributor Author

Very sorry for the late, this was a task of my classmate, my teacher assigned me other tasks that delayed the development of this PR, I'll get it down as soon as possible. Sorry for any troubles brought by my delay.

@myfreescalewebpage
Copy link
Collaborator

No worries @cybertale just wanted to know if you still want to work on it, take your time to complete it if required! Cheers, Joel

@cybertale
Copy link
Contributor Author

@myfreescalewebpage Hi Joel, I moved pin 17-28 left for 0.05 and fixed the fab layer dimension conflict. But I didn't find the RF_Wifi directory in module(Maybe my fault, there was one but not now), so I left it in RF_Module.

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Mar 21, 2019

Hi @cybertale thanks for the fixes here too!

  • For the RF_WiFi, seems it does not exist at all at the moment, you can create it, just think to also modify "fp-lib-table" file
  • Fab layer is OK for me know. But Silkscreen and CrtYd layer are not. Distance between Fab and Silkscreen lines should be 0.12mm and clearance around the device to the CrtYd layer should be 0.25mm. It is not exactly the right dimensions actually.
    Joel

@cybertale
Copy link
Contributor Author

@myfreescalewebpage Hi joel, I was planning to push them as two commits but empty folder is not allowed in git. This is also the reason why I cannot fix this ci error.

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Mar 21, 2019

Thanks for the creation of RF_Wifi. It is still not yet correct for position of silkscreen and CrtYd lines. Here is an schema with expected dimensions:

Capture

Note that distance to the lines is measured to the middle of the line.

@cybertale
Copy link
Contributor Author

@myfreescalewebpage Hi Joel, how about this time?

@myfreescalewebpage
Copy link
Collaborator

I do not agree with the top CrtYd line, as shown on the following screenshot, the distance should be 0.25mm here too.

Capture

Else this is great for me on the other lines.
Joel

@cybertale cybertale force-pushed the USR-C322 branch 2 times, most recently from b96aa69 to 523f5c4 Compare April 11, 2019 00:56
USR-C322 USR-C322 is a 3Mbps, 2.4GHz IEEE802.11 b/g/n WiFi Module.

Signed-off-by: Song Qiang <songqiang1304521@gmail.com>
@cybertale
Copy link
Contributor Author

@myfreescalewebpage Hi Joel, is this all right?

@myfreescalewebpage
Copy link
Collaborator

Thanks @cybertale looks great for me now :) Merging your contribution
Thanks for this job!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants