-
Notifications
You must be signed in to change notification settings - Fork 951
pretty repositories reorganization #257
Comments
I like it! If everybody agree that it's time to make big changes I'm ready to help. I think that the first thing to do is to remove whatever can be removed. I've also some suggestions/questions/ideas about the table: Air_Coils_SML_NEOSID.pretty - ok, alternatively may be moved to Inductors_NEOSID.pretty (if will be left) Capacitors_Elko_ThroughHole.pretty - action 1 is done, this library can be removed (maybe "universal" footprints should be saved). All Chokes and Inductors - it may be hard to sort them in a wise way because often the same element may be used as choke or not-choke. Inductors is more general name. "Toroids" may be chokes, inductors or transformers. All four libraries with crystals and oscillators - I'd suggest creating: Crystals.pretty and Oscillators.pretty (without SMD/THT because there is not much content yet) Displays LCD and LED - I like it but if somebody will add some different type of display there will be problem to classify them. Graphics/7-segm is also bad. Maybe this needs to be discussed. Simplest solution: Displays.pretty EuroBoard_Outline.pretty - if nobody can prove it's really useful I'm for removing. Hall-Effect_Transducers_LEM.pretty and PFF_PSF_PSS_Leadforms.pretty - go to new Hall-Effect_Transducers.pretty, it seems to be the same type of current sensing devices Resistors_Universal.pretty - as was discussed: rename to Universal.pretty and put here more different universal footprints Oddities.pretty, Wire_Pads.pretty, Wire_Connections_Bridges.pretty - maybe put them into one library, then remove some of footprints or maybe remove at least one library. Opto-Devices.pretty - I think it should be left Sockets_BNC.pretty - rename to RF_Connectors to be more general or maybe even "signal_connectors" (maybe needs better name) to include also audio connectors, or "coaxial_connectors" (quite wide class of "analog" connectors)? Sockets_PGA.pretty - this footprint is in another library so this one should be deleted Transistors_SMD.pretty - same as Transistors_TO-220.pretty and others (move to TO_SOT_Packages_*) Socket_Strips.pretty and Pin_Headers.pretty has different 3d models and (in some cases) different pin numbering. I think they can be left as is or put into one library. I'm not sure if adding _THT is necessary. We haven't even smd footprints of this type. Transistors_OldSowjetAera.pretty, - some new library for rarely used, hard to classify footprints would be usefull but I've no idea how to name it. Power_Packages_* - to be removed if all my pull requests will be merged. |
I moved the table to google doc to keep easy to update. @michal777 I applied some changes you suggested and left some to solve/to discuss. They are:
move all to chokes.pretty or inductors.pretty ?
left as is?
move to inductors.pretty?
move to ...?
left as is?
left as is or or move to only one repo?
left as is or or move to only one repo?
move all to sockets.pretty ? move to connectors?
move to sockets.pretty ? move to connectors? left as is?
move to ...?
left as is or or move to only one repo? if one, which name? |
Next post to discussion:
|
I've looked into the mess in connectors and sockets. There are following libraries:
So maybe:
This way all libraries, apart from Sockets, will start with "Connectors_" and will be together on a alphabetically sorted list of footprints. |
Update: it seems the confusion arises because new installs of 4.0.0 or 4.0.1 do NOT update the fp-lib-table that resides in a user directory both on Win and Linux installs. A manual update of fp-lib-table fixes the problem. Something for the packaging-team to consider - updating to the latest KiCad now breaks library functionality for many users because of this fp-lib-table issue. It seems the libraries have been reorganized on github, but the fp-lib-table.for-github file has not been updated!? |
The problem is that bleeding edge users uses fp-lib-table installed with some unstable release instead of their own libraries (off-line or personal github). |
I'd like to start doing some changes. Renaming the following repositories: Buttons_Switches_ThroughHole.pretty -> Buttons_Switches_THT.pretty @michal777 and @CarlPoirier can I do this changes now? |
Because of the f#^&@!* kicad github online libraries, removing libraries will cause error messages which are confusing for beginners who suffer from the github fp-lib-table installed by default with some packages/installers of the kicad. |
I would link my proposal for connectors cleanup: #368 (comment) In a nutshell, moving some |
OK so to put it all together: Buttons_Switches_ThroughHole.pretty -> Buttons_Switches_THT.pretty A copy of the libraries to be renamed need to be kept in their original state as well for people using fp-lib-table.for-github but not knowing how it works. |
other suggestions:
|
Indeed, no more Terminal_Blocks. As for the TO-SOT, I don't see any benefit of renaming them. Furthermore they are new libraries. SMD_Packages is meant to disappear but we never got to it completely yet! I'm not sure about Wire_Pads. |
One more thing to do is to sort out the path to .3dshapes somehow. Currently the only place where .3dshapes are found is /usr/share/kicad/modules/packages3d. It would be good to have something like ${KIPRJMOD} (KIPRJ3DMOD?) but for 3D files, so that projects can use their private .3dshape files. Currently I have to make a link to them to /usr/share/... and this is horrible. And in general, the .wings files should be excluded from the KiCad distribution. They should be available from the kicad-library repo, just like the .kicad_pcb files with footprints. This Wings3D software is cumbersome and there are little people that can use it, so why copy it to every KiCad user's HDD? |
@anpaza et al, I think that the 3D files should each have their own repository (e.g. Housings_SSOP.3dshapes becomes a repository). Each .pretty repo gets a matching .3dshapes repo. I think this is a good solution for a few reasons:
|
@anpaza @SchrodingersGat In current build (since build 6697, patch here), 3D path is defined separately. AFAIK it is accessible only through footprint 3D settings. There is Configure path button, where you define aliases and paths to directories where are *.3dshapes/ directories located. Then you can use alias:library.3dshapes/model.wrl as filename of model. Unfortunately it is global and if you define some non global alias like ${KIPRJMOD}/3D kicad will inform you about wrong path at projects without 3D subdir. Wings file and even wrl file will be abandoned in future after switching to STEP file format IIRC. More questions about this topic could be answered through bugreport, here it is OffTopic. |
Bumping this thread, specifically relating to the inductor / choke repositories. I currently have a number of PRs outstanding @ https://github.com/KiCad/Inductors.pretty @anpaza has a very large PR outstanding @ https://github.com/KiCad/Choke_SMD.pretty Plus, there are the other choke related repositories:
Before these PRs are addressed, I think some action needs to be taken here. Personally, I would like to see two libraries:
and the existing footprints can be migrated to there as required. What do we all think of this? @CarlPoirier as the man with the power to raise and cull repos, I'm hoping you will weigh in :) |
If no one has any strong opinions, I would settle for a moderately interested one, even. What do people think of having two consolidated repositories:
|
That does sound like "oily oil". |
I agree with anpaza, that also conforms to michal777. |
I'd go with Inductors*.lib(s) only. Chokes are special case of inductors. I made common mistake, it should be _SMT and _THT suffixes. I agree with @anpaza. some explanation...
Umm, what? I don't know what do you mean by our, but eg. 90% of parts on my PCBs are SMD and as THT remains connectors and high power parts only. |
SMT is by no means "rare" or "special", agreed. I think the additional "_SMT" suffix adds specificity at the cost of only /2c On 16 Jul 2016 3:26 am, "Patrik Bachan" notifications@github.com wrote:
|
Since changes in libraries cause problems to user who don't know how the fp-lib-table works, we have to keep changes to a minimum. I agree for splitting the Inductors in SMD and THT repos while marking the old one as deprecated. Furthermore, chokes being specific a specific use for inductors, I see no problem in them having their own repository. That being said, the existing choke repositories exist for historical reasons (the easy excuse haha) but indeed could be replaced. All in all, Inductors_SM*.pretty and Chokes_SM*.pretty would fit the bill. |
If chokes are split into a separate library, I expect appearing people opting for splitting power inductors, high-freq inductors etc into separate libraries. P.S. Strange, the site engine replaces "BEHIND" with "BIND", test: behind, be hind, behi nd, mwahaha. |
The difference with chokes is that they are already split. Also, one thing to keep in mind is that the bigger the .pretty is, the longer it takes to load it from Github. |
@CarlPoirier have we reached somewhat of an accord on this? If you want to make the appropriate new repositories we can start reassigning parts etc etc :) |
@CarlPoirier, @SchrodingersGat , ... It would be cool to get to a conclusion and then start reordering the footprints. |
Hi @pointhi, That's where we were at. Indeed, lets's go ahead. I'll start by merging the pull requests you have already open later this weekend. Buttons_Switches_ThroughHole.pretty -> Buttons_Switches_THT.pretty Also all of those into Chokes_SMT.pretty and Chokes_THT.pretty: And those into Inductors_SMT.pretty and Inductors_THT.pretty: |
For chokes, there are another repositories which also needs to be merged: |
Indeed I had not mentioned the Air_Coils_SML_NEOSID.pretty. Also I just noticed that for simple renames, we need not keep the old repo since Github offers repository redirection! |
I thought the links in the summary were pull requests. You can go ahead and add symbols into the new repos. I will take care of the renaming. |
You mean Inductors_SMT and Inductors_THT, yes? |
woops, indeed! I will edit the summary. |
I completed the simple renames with pull #743. What is left to do, which all require leaving the old repositories online: Sockets_MOLEX_KK-System.pretty -> Connectors_Molex.pretty (KiCad/Sockets_MOLEX_KK-System.pretty#1) Also all of those into Chokes_SMT.pretty and Chokes_THT.pretty: And those into Inductors_SMT.pretty and Inductors_THT.pretty: |
Sweeping changes have now been made addressing most (all?) of these issues. I am going to mark this one as closed |
Michal's proposal extension to all pretty repositories, check: KiCad/TO_SOT_Packages_SMD.pretty#1
Check suggestions in this google doc spreadsheet
The text was updated successfully, but these errors were encountered: