Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added symbols for TE PE0xxFxx bistable latching relays. Replaces PR #2649. #2946

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

amil109
Copy link
Contributor

@amil109 amil109 commented Aug 29, 2020

This PR replaces #2649, which can be closed.

Added symbols for TE PE0xxFxx bistable latching relays.

Based on OMRON G5Q-1 footprint.

https://www.te.com/commerce/DocumentDelivery/DDEController?Action=showdoc&DocId=Data+Sheet%7FPE_bistable%7F0919%7Fpdf%7FEnglish%7FENG_DS_PE_bistable_0919.pdf%7F3-1415390-1

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

[ x ] Provide a URL to a datasheet for the symbol(s) you are contributing
[ x ] An example screenshot image is very helpful
TE_PE0xxFxx_CO_symbol
image

TE_PE0xxFxx_NO_symbol
image

[ x ] Ensure that the associated footprints match the official footprint library
A new fitting footprint must be submitted if the library does not yet contain one.
[ x ] If there are matching footprint PRs, provide link(s) as appropriate
KiCad/kicad-footprints#2225

[ TBC ] Check the output of the Travis automated check scripts - fix any errors as required
[ NA ] Give a reason behind any intentional library convention rule violation.


⚠️ Deprecation warning

In preparation for the KiCad v6 release this repository will be locked down on Sept 1, 2020. No new pull requests will be accepted. Existing pull requests can be worked on until Oct 1, 2020. Changes breaking v5.1 compatibility can be merged starting Sept 1, 2020.

On Oct 1, 2020 this repository, including issues and pull requests, will be archived and transferred to gitlab.com. In order for your pull requests and issues to be imported into GitLab you must set your email address on GitHub to public and use the same address for your GitLab account. Or login to GitLab at least once using the GitHub icon. Otherwise the importer can't correlate the account information and the issues/comments on GitLab will be owned by kicad-bot (importer documentation).

We plan to convert the library to the new v6 S-expr format after it is imported to GitLab. That also means that old pull requests will need to be redone with the v6 format if they are not merged before then.


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging Re-push This is a new attempt of an abandoned PR labels Aug 30, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Aug 30, 2020
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Sep 4, 2020

Hi @amil109 , thanks for contributing,

A few comments I have during my review:

TE_PE0xxFxx_CO

  • The name should be "PE01xFxx"
  • The footprint should be Relay_THT:Relay_SPDT_TE_PE01xFxx
  • The fp filter Relay*SPDT*TE*PE01xFxx*

TE_PE0xxFxx_NO

  • The name should be "PE03xFxx"
  • The footprint should be Relay_THT:Relay_SPDT_TE_PE03xFxx
  • The fp filter Relay*SPDT*TE*PE03xFxx*

Cheers,
Joel

Updated to correct model numbers.
Updated as requested.
@amil109
Copy link
Contributor Author

amil109 commented Sep 6, 2020

Hi Joel,

Thank you for coming back so quickly - that's this PR updated as requested, and PR#2225 for the footprints has been updated to match.

Please let me know if any other changes are needed, and thank you again!

Cheers,

Andrew

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Sep 8, 2020

Thanks for the update.
Regarding to the name of the symbol, the manufacturer is not expected in the name, please remove "TE_"
Same comment for the contact type at the end of footprints
Joel

@myfreescalewebpage myfreescalewebpage added the Abandoned Original author has stopped working on the PR label Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Abandoned Original author has stopped working on the PR Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging Re-push This is a new attempt of an abandoned PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants