fix: Improve status refreshing logic

KieraDOG · Aug 12, 2024 · dc782ef · dc782ef
1 parent dea0dac
commit dc782ef
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/src/CGDGarageDoor.ts b/src/CGDGarageDoor.ts
@@ -145,23 +145,29 @@ export class CGDGarageDoor {
   private refreshStatus = async () => {
     this.log.debug(`Refreshing status... ${this.isUpdating}`);
     if (this.isUpdating) {
-      this.log.debug('Skip');
+      this.log.debug('Skip refreshing status because it is updating');
 
       return;
     }
 
     const status = await this.getStatus();
-    if (!status || this.isStatusEqual(status)) {
+    if (this.isStatusEqual(status)) {
+      this.log.debug('Skip updating status because it is equal');
+      return;
+    }
+
+    if (this.isUpdating) {
+      this.log.info('Skip updating status because it is updating');
       return;
     }
 
     this.status = status;
     this.statusUpdateListener?.();
   };
 
-  private isStatusEqual = (data: Status) => {
+  private isStatusEqual = (data?: Status) => {
     const values = ['lamp', 'door', 'vacation'];
-    return values.every((value) => this.status?.[value] === data[value]);
+    return values.every((value) => this.status?.[value] === data?.[value]);
   };
 
   private poolStatus = async () => {