Logistic module pt. 2 #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wyqer
requested changes
Apr 7, 2019
There was a problem hiding this comment.
Very huge addition, great contribution to the project. 👍
Some smaller changes requested like removing "player" in the getFOB call, as it's the default value for the function.
Haven't marked it, but many functions miss the Public attribute, maybe you want to go through all of the ones which are added in the PR and add the attribute.
Missionframework/modules/23_logistic/fnc/fn_logistic_resupplyTarget.sqf
Outdated
Show resolved
Hide resolved
Missionframework/modules/23_logistic/fnc/fn_logistic_selectRecycleTarget.sqf
Outdated
Show resolved
Hide resolved
Missionframework/modules/23_logistic/fnc/fn_logistic_selectResupplyTarget.sqf
Outdated
Show resolved
Hide resolved
Missionframework/modules/26_cratefiller/fnc/fn_cratefiller_addEquipment.sqf
Outdated
Show resolved
Hide resolved
Missionframework/modules/26_cratefiller/fnc/fn_cratefiller_getInventory.sqf
Outdated
Show resolved
Hide resolved
Missionframework/modules/26_cratefiller/fnc/fn_cratefiller_getNearStorages.sqf
Outdated
Show resolved
Hide resolved
Missionframework/modules/26_cratefiller/fnc/fn_cratefiller_removeEquipment.sqf
Outdated
Show resolved
Hide resolved
Missionframework/modules/26_cratefiller/fnc/fn_cratefiller_setInventory.sqf
Outdated
Show resolved
Hide resolved
Co-Authored-By: Dubjunk <31448659+Dubjunk@users.noreply.github.com>
Co-Authored-By: Dubjunk <31448659+Dubjunk@users.noreply.github.com>
Co-Authored-By: Dubjunk <31448659+Dubjunk@users.noreply.github.com>
Co-Authored-By: Dubjunk <31448659+Dubjunk@users.noreply.github.com>
Co-Authored-By: Dubjunk <31448659+Dubjunk@users.noreply.github.com>
Co-Authored-By: Dubjunk <31448659+Dubjunk@users.noreply.github.com>
Wyqer
approved these changes
Apr 7, 2019
Wyqer
requested changes
Apr 7, 2019
Co-Authored-By: Dubjunk <31448659+Dubjunk@users.noreply.github.com>
Wyqer
approved these changes
Apr 7, 2019
veteran29
approved these changes
Apr 7, 2019
| // find configclass | ||
| switch true do | ||
| { | ||
| case (isClass (configFile >> "CfgMagazines" >> _classname)): {"CfgMagazines"}; |
There was a problem hiding this comment.
It would be a lot faster if the function would return config itself instead of an string.
Also the result could be cached in namespace for faster access in subsequent calls to this function.
see: KPLIB_fnc_common_getIcon
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the cratefiller to the logistic station and includes several code optimizations.
Also the resource module is now fully integrated into the recycle and resupply functions.
Content:
Successfully tested on:
Compatibility checked with: