Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.96.6 - Increasing sector despawn time #666

Merged
merged 7 commits into from
Sep 6, 2019
Merged

v0.96.6 - Increasing sector despawn time #666

merged 7 commits into from
Sep 6, 2019

Conversation

veteran29
Copy link
Member

@veteran29 veteran29 commented Sep 5, 2019 •
edited
Loading

Q A
Bug fix? no
New feature? yes
Needs wipe? no
Fixed issues -

Description:

Makes sector despawn time more dynamic by increasing the time of sector deactivation delay by multiplying default deactivation time by the amount of minutes the sector was activated, starting from fifth activation minute.

Increased despawn time is added to base despawn time.

IF minutes_running < 5:
    despawn_time = BASE_DESPAWN_TIME
ELSE
    despawn_time = BASE_DESPAWN_TIME + ((minutes_running - 5) * BASE_DESPAWN_TIME )

BASE_DESPAWN_TIME is ~60s by default (depending on scheduler load)

Content:

  • Increasing despawn time functionality
  • Maximum increased despawn time parameter, 5 mins default

Successfully tested on:

  • Local MP
  • Dedicated MP

Compatibility checked with:

  • Nothing

veteran29 and others added 2 commits September 3, 2019 21:43
@veteran29
Sector deactivation delay parameter
00c869e 
After 5th minute from sector activation time the time required to deactivate will increase for one minute after every minute. Up to the selected limit (5 mins by default).
@veteran29
Add despawn scaling changelog entry
111e815
@veteran29 veteran29 added this to the v0.96.6 milestone Sep 5, 2019
@veteran29 veteran29 requested review from Wyqer and Dubjunk September 5, 2019 14:36
@veteran29 veteran29 self-assigned this Sep 5, 2019
@Wyqer Wyqer added the review/QA label Sep 5, 2019
Wyqer
Wyqer requested changes Sep 5, 2019
View reviewed changes
Copy link
Member

@Wyqer Wyqer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just the strings, some more values to choose from and the resolving of the merge conflicts.

Missionframework/stringtable.xml Show resolved Hide resolved
Missionframework/ui/mission_params.hpp Outdated Show resolved Hide resolved
Missionframework/ui/mission_params.hpp Outdated Show resolved Hide resolved
@Wyqer Wyqer merged commit 7d97e30 into v0.96.6 Sep 6, 2019
@Wyqer Wyqer deleted the v0.96.6-despawn-scaling branch September 6, 2019 11:14
@Wyqer Wyqer added done and removed review/QA labels Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyqer Wyqer Wyqer approved these changes

@Dubjunk Dubjunk Awaiting requested review from Dubjunk

Assignees

@veteran29 veteran29

Labels
None yet
Projects
None yet
Milestone
v0.96.6
Development

Successfully merging this pull request may close these issues.
2 participants
@veteran29 @Wyqer