Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

will onEditorCreated emit for several times or should it complete? #1590

Closed
KingMario opened this issue Aug 16, 2022 · 2 comments
Closed

will onEditorCreated emit for several times or should it complete? #1590

KingMario opened this issue Aug 16, 2022 · 2 comments

Comments

@KingMario
Copy link

Hi @KillerCodeMonkey,

I'd like to know if onEditorCreated will be emitted multiple times?

If onEditorCreated is emitted at most once, should its complete method be called?

Otherwise, in practice, I would unsubscribe the subscription in ngOnDestroy of my component.

Thanks for your great work and looking forward to your answer.

@KillerCodeMonkey
Copy link
Owner

KillerCodeMonkey commented Aug 16, 2022 via email

@KillerCodeMonkey
Copy link
Owner

in v19.0.1 the subject is closed right after emitting that editors or initialized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants