Skip to content

Commit

Permalink
Merge pull request #34 from Kiln-AI/windows_av_fp
Browse files Browse the repository at this point in the history
Improve Windows Build: installer instead of "--onefile"
  • Loading branch information
scosman authored Nov 14, 2024
2 parents 298f337 + 9e66676 commit 972e0cf
Show file tree
Hide file tree
Showing 2 changed files with 59 additions and 3 deletions.
58 changes: 58 additions & 0 deletions app/desktop/WinInnoSetup.iss
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
; Script generated by the Inno Setup Script Wizard.
; SEE THE DOCUMENTATION FOR DETAILS ON CREATING INNO SETUP SCRIPT FILES!

#define MyAppPath "APP_PATH_TEMPLATE"
#define MyAppName "Kiln"
#define MyAppVersion "0.5.6"
#define MyAppPublisher "Chesterfield Laboratories Inc"
#define MyAppURL "https://getkiln.ai"
#define MyAppExeName "Kiln.exe"

[Setup]
; NOTE: The value of AppId uniquely identifies this application. Do not use the same AppId value in installers for other applications.
; (To generate a new GUID, click Tools | Generate GUID inside the IDE.)
AppId={{0D014F6B-4438-45BC-A8D5-DD6AF90DFF1F}
AppName={#MyAppName}
AppVersion={#MyAppVersion}
;AppVerName={#MyAppName} {#MyAppVersion}
AppPublisher={#MyAppPublisher}
AppPublisherURL={#MyAppURL}
AppSupportURL={#MyAppURL}
AppUpdatesURL={#MyAppURL}
DefaultDirName={autopf}\{#MyAppName}
DisableDirPage=yes
; "ArchitecturesAllowed=x64compatible" specifies that Setup cannot run
; on anything but x64 and Windows 11 on Arm.
ArchitecturesAllowed=x64compatible
; "ArchitecturesInstallIn64BitMode=x64compatible" requests that the
; install be done in "64-bit mode" on x64 or Windows 11 on Arm,
; meaning it should use the native 64-bit Program Files directory and
; the 64-bit view of the registry.
ArchitecturesInstallIn64BitMode=x64compatible
DisableProgramGroupPage=yes
; Remove the following line to run in administrative install mode (install for all users.)
PrivilegesRequired=lowest
PrivilegesRequiredOverridesAllowed=dialog
OutputBaseFilename=kilnsetup
Compression=lzma
SolidCompression=yes
WizardStyle=modern

[Languages]
Name: "english"; MessagesFile: "compiler:Default.isl"

[Tasks]
Name: "desktopicon"; Description: "{cm:CreateDesktopIcon}"; GroupDescription: "{cm:AdditionalIcons}"; Flags: unchecked

[Files]
Source: "{#MyAppPath}\{#MyAppExeName}"; DestDir: "{app}"; Flags: ignoreversion
Source: "{#MyAppPath}\_internal\*"; DestDir: "{app}\_internal"; Flags: ignoreversion recursesubdirs createallsubdirs
; NOTE: Don't use "Flags: ignoreversion" on any shared system files

[Icons]
Name: "{autoprograms}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"
Name: "{autodesktop}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"; Tasks: desktopicon

[Run]
Filename: "{app}\{#MyAppExeName}"; Description: "{cm:LaunchProgram,{#StringChange(MyAppName, '&', '&&')}}"; Flags: nowait postinstall skipifsilent

4 changes: 1 addition & 3 deletions app/desktop/build_desktop_app.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@ else
echo "Building Windows App"
cp desktop/win_taskbar.png desktop/build/taskbar.png
cp desktop/win_icon.png desktop/build/icon.png
# onefile launches slower, but compiles whole app into a single .exe
# TODO: should use --windowed on Windows, but it doesn't work and needs debugging
PLATFORM_OPTS="--onefile --windowed --splash=../win_splash.png"
PLATFORM_OPTS="--windowed --splash=../win_splash.png"
fi

# Builds the desktop app
Expand Down

0 comments on commit 972e0cf

Please sign in to comment.