Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No std #63

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

No std #63

wants to merge 3 commits into from

Conversation

lengyijun
Copy link

can pass

cargo b
cargo b --features=no_std
cargo test

can not pass

cargo test  --features no_std

I'm not quite sure my modification is right yet. If there is some problems, I'd like to modify it more

@lengyijun lengyijun closed this Jun 22, 2020
@lengyijun lengyijun reopened this Nov 8, 2020
@lengyijun
Copy link
Author

I still feel no_std is necessary

@ogoffart
Copy link

I would also like to use this crate in a no_std context. Is this crate still maintained?

Regarding this PR, i don't think this is the way to do it. Rust feature are meant to be additive, so we cannot have a no_xxx feature, instead, we need to have positive features, like std, which is proposed in this PR, which i believe is a better approach: #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants