Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocketmq Protocol Identification and Analysis #328

Merged
merged 5 commits into from
Nov 30, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add CHANGELOG and metrics doc
Signed-off-by: thenicetgp <13120413800@163.com>
  • Loading branch information
thenicetgp committed Nov 30, 2022
commit 6efdd7ea2b2b7f136e43dbbf74ecc6700c1efb5f
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
## Unreleased
### New features
-
-
- Support the protocol RocketMQ.([#328](https://github.com/KindlingProject/kindling/pull/328))
- Add a new tool: A debug tool for Trace Profiling is provided for developers to troubleshoot problems.([#363](https://github.com/CloudDectective-Harmonycloud/kindling/pull/363))


8 changes: 8 additions & 0 deletions docs/prometheus_metrics.md
Original file line number Diff line number Diff line change
@@ -75,6 +75,13 @@ Service metrics are generated from the server-side events, which are used to sho
| `request_content` | GET | The command of the Redis request. |
| `response_content` | noerror | The value is either `error` or `noerror`. |

- When protocol is `rocketmq`:

| **Label** | **Example** | **Notes** |
| --- |-------------|-------------------------------------------------------------------|
| `request_content` | TopicTest | Topic of RocketMQ request. |
| `response_content` | 0 | response code of RocketMQ. 0 means OK, others mean Error [docs](https://github.com/apache/rocketmq/blob/fcfe26e4443dd24b1055899266d1bd81060ee118/common/src/main/java/org/apache/rocketmq/common/protocol/ResponseCode.java) |

- For other cases, the `request_content` and `response_content` are both empty.

**Note 3**: The histogram metric `kindling_entity_request_average_duration_nanoseconds_*` is disabled by default as it could be high-cardinality. If this metric is needed, please add a new line to the `exporters.otelexporter.metric_aggregation_map` section of the configuration file.
@@ -140,6 +147,7 @@ These two terms are composed of two parts.
- **mysql**: `Error Code` of the error response.
- **dubbo**: `Error Code` of Dubbo request.
- **redis**: `0` if there is no error; `1` otherwise.
- **rocketmq**: `Response Code` of RocketMQ response.
- **others**: empty temporarily.

**Note 3**: The histogram metric `kindling_topology_request_average_duration_nanoseconds_*` is disabled by default as it could be high-cardinality. If this metric is needed, please add a new line to the `exporters.otelexporter.metric_aggregation_map` section of the configuration file.