Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tap Dance does not work - devicetree error: ... lacks binding #13

Closed
taylon opened this issue Sep 22, 2022 · 2 comments
Closed

Tap Dance does not work - devicetree error: ... lacks binding #13

taylon opened this issue Sep 22, 2022 · 2 comments

Comments

@taylon
Copy link

taylon commented Sep 22, 2022 •
edited
Loading

Hello,

When trying to setup tap dance behaviors I get the following error:

devicetree error: binding controller <Node /behaviors/tap_dance_xxx 'adv360_left.dts.pre.tmp'> for <Node /keymap/default_layer in 'adv360_left.dts.pre.tmp'> lacks binding

Here is the keymap definition: https://github.com/taylon/Adv360-Pro-ZMK/blob/V1.0/config/adv360.keymap
Here is a build with the error: https://github.com/taylon/Adv360-Pro-ZMK/actions/runs/3102414540/jobs/5024689982

  • I tried to update the ZMK docker image to stable and 3.0 instead of 2.4 and that did not make a difference.
  • If I remove the reference to the tapdance behavior from the layer definition it compiles just fine.
  • Seached in the zmk and zephyr repos to see if there is any reference to this error and could not find anything
  • The error message seems to be triggered here
  • I tried to use the exact same tap dance definiton showed in the documentation here (I mean I replaced the whole keymap with that) and got the same error, which is what makes me believe that this might be an issue with the Adv360 setup as opposed to a bug in zmk (I might be wrong though)

Unfortunately I can't migrate from my Kinesis Advantage 2 (which runs QMK) until I have tap dance :(
@ringil-forge
Copy link

@taylon have you tried building your firmware from the V2.0-beta branch? I am running that branch locally and was able to successfully build your keymap.

@taylon
Copy link
Author

taylon commented Sep 23, 2022

Oh nice, I did not notice that, it worked indeed.

Thanks,

@taylon taylon closed this as completed Sep 23, 2022
jonatan-branting pushed a commit to jonatan-branting/Adv360-Pro-ZMK that referenced this issue Feb 1, 2024
@adv360proapp @jonatan-branting
# This is a combination of 16 commits.
1cbbfec 
# This is the 1st commit message:

Updated keymap
# The commit message KinesisCorporation#2 will be skipped:

# Updated keymap

# The commit message KinesisCorporation#3 will be skipped:

# feat: Add basic changes to make me feel more at home

# The commit message KinesisCorporation#4 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#5 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#6 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#7 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#8 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#9 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#10 will be skipped:

# Reduce brightness of leds

# The commit message KinesisCorporation#11 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#12 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#13 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#14 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#15 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#16 will be skipped:

# Updated adv360.keymap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@taylon @ringil-forge