Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional pedal keys #114

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Conversation

ReFil
Copy link
Collaborator

@ReFil ReFil commented Mar 4, 2023

Adds pedal2 keys on left and right back into matrix, can help sort mystery keypresses

Adds pedal2 keys on left and right back into matrix
@ReFil ReFil merged commit 80885e6 into KinesisCorporation:V2.0 Mar 4, 2023
@ottobonn
Copy link

ottobonn commented Mar 6, 2023

Hello, it looks like this might have broken the generated keymaps of the GUI editor. Now the maps it generates have the keys shifted over because it is not producing placeholders for the pedals.

@ReFil
Copy link
Collaborator Author

ReFil commented Mar 6, 2023

Sorry about this, just waiting for the fix to test build then i will merge the fix

@tarsius
Copy link

tarsius commented Mar 7, 2023

can help sort mystery keypresses

I have assumed that the pedal keys were there for purely cosmetic reasons; to help generating images of the keyboard, or something like that. I found them distracting and was considering removing them eventually. Would you be so kind and briefly explain how these fake keys help with avoiding mystery keypresses? Thanks!

@OlivierNicole
Copy link

can help sort mystery keypresses

This seems to solve the issue of out-of-thin-air keypresses that I’ve been having. I have no idea why, but well… good news for me.

tricktux pushed a commit to tricktux/Adv360-Pro-ZMK that referenced this pull request Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants