Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MacOS makefile vvars #339

Closed
wants to merge 2 commits into from

Conversation

ReFil
Copy link
Collaborator

@ReFil ReFil commented Jan 17, 2024

Advantage 360 Pro PR template

What's changed:

The OS auto detection in the makefile has been expanded so more variables are not quoted when running under MacOS

Why has this change been implemented:

#335 Broke compatibility on MacOS

What (if any) actions must a user take after this change:

No additional actions need to be taken

Copy link

@gaheeoh gaheeoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pulls from kinesis

@huber-th
Copy link
Contributor

huber-th commented Feb 3, 2024

Is this an issue for a specific version of macOS? I'm on Sonoma 14.3 (Apple Silicon M2) and have no issues with the OS detection as it is implemented in branch V3.0

@ReFil
Copy link
Collaborator Author

ReFil commented Feb 5, 2024

Not sure, We had a user reporting this as an issue but i cant for the life of my find the issue report now

@ReFil
Copy link
Collaborator Author

ReFil commented Feb 12, 2024

Closing as seems to be unnecessary

@ReFil ReFil closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants