Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document new layer colors and modifier color configuration option #431

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Document new layer colors and modifier color configuration option #431

merged 5 commits into from
Apr 15, 2024

Conversation

khoek
Copy link
Contributor

@khoek khoek commented Apr 7, 2024 •
edited
Loading

Add documentation for ReFil/zmk#18 and ReFil/zmk#19.

Here it is rendered.

@khoek khoek mentioned this pull request Apr 7, 2024
Merged
@khoek khoek force-pushed the new-docs branch 2 times, most recently from 9f725f7 to 0013b0d Compare April 7, 2024 15:09
@ReFil
Copy link
Collaborator

ReFil commented Apr 8, 2024

CONFIG_ZMK_RGB_UNDERGLOW_MOD_COLOR needs to be set on both sides right? it may be worth clarifying that in the docs

@khoek
Copy link
Contributor Author

khoek commented Apr 10, 2024

Sorry, I'd missed this.

@ReFil
Copy link
Collaborator

ReFil commented Apr 15, 2024

Please can you rebase as there were some other changes to the zephyr 3.5 PR? It would also be good if you could link to the base ZMK PR's in the changelog entries. Thank you

@khoek
Copy link
Contributor Author

khoek commented Apr 15, 2024

How does that look?

@ReFil
Copy link
Collaborator

ReFil commented Apr 15, 2024

Spot on, thank you very much!

@ReFil
Copy link
Collaborator

ReFil commented Apr 15, 2024

Waiting for build job then i'll hit merge, thank you again for all your work on these features <3

@ReFil ReFil merged commit 41e734c into KinesisCorporation:V3.0 Apr 15, 2024
1 check passed
@khoek khoek deleted the new-docs branch April 15, 2024 11:30
ztomer pushed a commit to ztomer/Adv360-Pro-ZMK that referenced this pull request Apr 16, 2024
@khoek @ReFil @ztomer
Document new layer colors and modifier color configuration option (Ki…
a2d28eb 
…nesisCorporation#431)

Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com>
ztomer pushed a commit to ztomer/Adv360-Pro-ZMK that referenced this pull request Apr 16, 2024
@khoek @ReFil @ztomer
Document new layer colors and modifier color configuration option (Ki…
19cc6fb 
…nesisCorporation#431)

Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com>
gabrielfreiberg added a commit to gabrielfreiberg/Adv360-Pro-ZMK that referenced this pull request May 5, 2024
@gabrielfreiberg
Merge branch 'upstream_V3.0'
84dbcb2 
* upstream_V3.0:
  Changelog update (KinesisCorporation#448)
  Minor docs update (KinesisCorporation#445)
  Document new layer colors and modifier color configuration option (KinesisCorporation#431)
  Zephyr 3.5 Update (KinesisCorporation#426)
  Fix Makefile errors that prevent builds on macOS (KinesisCorporation#409)
  Fix version.dtsi is reset after local firmware build (KinesisCorporation#385)
  Update build workflows (KinesisCorporation#376)
gabrielfreiberg added a commit to gabrielfreiberg/Adv360-Pro-ZMK that referenced this pull request May 5, 2024
@gabrielfreiberg
Merge branch 'main' into mod-layer
56f0bf3 
* main:
  Changelog update (KinesisCorporation#448)
  Minor docs update (KinesisCorporation#445)
  Document new layer colors and modifier color configuration option (KinesisCorporation#431)
  Zephyr 3.5 Update (KinesisCorporation#426)
  Fix Makefile errors that prevent builds on macOS (KinesisCorporation#409)
  Fix version.dtsi is reset after local firmware build (KinesisCorporation#385)
  Update build workflows (KinesisCorporation#376)
asmodeus812 added a commit to asmodeus812/Adv360-Pro that referenced this pull request Jun 26, 2024
@asmodeus812 @ReFil @khoek
Update branch (#4)
a8d3d9a 
* Zephyr 3.5 Update (KinesisCorporation#426)

* Zephyr 3.5 update

* Changelog

* Document new layer colors and modifier color configuration option (KinesisCorporation#431)

Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com>

* Minor docs update (KinesisCorporation#445)

* Changelog update (KinesisCorporation#448)

---------

Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com>
Co-authored-by: Keeley Hoek <keeley@hoek.io>
zemackdaddy pushed a commit to zemackdaddy/Adv360-Pro-ZMK that referenced this pull request Jul 7, 2024
@khoek @ReFil
Document new layer colors and modifier color configuration option (Ki…
16d624f 
…nesisCorporation#431)

Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com>
cr0rc pushed a commit to cr0rc/Adv360-Pro-ZMK that referenced this pull request Jul 13, 2024
@khoek @ReFil @cr0rc
Document new layer colors and modifier color configuration option (Ki…
d881e4b 
…nesisCorporation#431)

Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com>
asmodeus812 pushed a commit to asmodeus812/Adv360-Pro that referenced this pull request Jul 16, 2024
@khoek @ReFil @asmodeus812
Document new layer colors and modifier color configuration option (Ki…
d6e7976 
…nesisCorporation#431)

Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com>
moritzschatz pushed a commit to moritzschatz/Adv360-Pro-ZMK that referenced this pull request Aug 24, 2024
@khoek @ReFil @moritzschatz
Document new layer colors and modifier color configuration option (Ki…
87618e0 
…nesisCorporation#431)

Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com>
jan-l pushed a commit to jan-l/Adv360-Pro-ZMK that referenced this pull request Aug 28, 2024
@khoek @ReFil @jan-l
Document new layer colors and modifier color configuration option (Ki…
f9f3ba7 
…nesisCorporation#431)

Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com>
shafayetkhan pushed a commit to shafayetkhan/Adv360-Pro-ZMK that referenced this pull request Sep 10, 2024
@khoek @ReFil @shafayetkhan
Document new layer colors and modifier color configuration option (Ki…
b1d0881 
…nesisCorporation#431)

Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com>
martypenner added a commit to martypenner/Adv360-Pro-ZMK that referenced this pull request Nov 6, 2024
@martypenner
Merge branch 'V3.0' into V2.0
9801a4f 
* V3.0: (40 commits)
  Changelog update (KinesisCorporation#448)
  Minor docs update (KinesisCorporation#445)
  Document new layer colors and modifier color configuration option (KinesisCorporation#431)
  Zephyr 3.5 Update (KinesisCorporation#426)
  Fix Makefile errors that prevent builds on macOS (KinesisCorporation#409)
  Fix version.dtsi is reset after local firmware build (KinesisCorporation#385)
  Update build workflows (KinesisCorporation#376)
  Makefile enhancements to optimize local workflows (KinesisCorporation#363)
  Update Makefile variables (KinesisCorporation#335)
  Base ZMK update (KinesisCorporation#326)
  Prefer `tr` to ${char^^}, which does not work on older bash versions (KinesisCorporation#303)
  Add version macro (KinesisCorporation#300)
  Add pull request template (KinesisCorporation#293)
  Revert "Updated keymap"
  Revert "Updated keymap"
  Updated keymap
  Updated keymap
  Make get_version use bash from $PATH (KinesisCorporation#287)
  Update bluetooth settings in light of user feedback (KinesisCorporation#289)
  Revert "Add version macro to keymap.json (KinesisCorporation#269)"
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khoek @ReFil