Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set character encoding explicitly in JSONStore #134

Merged
merged 3 commits into from
May 15, 2024
Merged

Set character encoding explicitly in JSONStore #134

merged 3 commits into from
May 15, 2024

Conversation

rkingsbury
Copy link
Member

Fixes #122

Prior to this PR, since the character encoding was not explicitly set, trying to read the database files on non-English platforms (or any platforms where the encoding is not UTF 8) would result in a UnicodeDecodeError. This PR fixes the problem by implementing the new encoding kwarg recently added to maggma.

@rkingsbury rkingsbury added the fix Bug Fixes label May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (a2ebba3) to head (3ae9a6e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   81.52%   81.52%           
=======================================
  Files           9        9           
  Lines        1429     1429           
  Branches      294      294           
=======================================
  Hits         1165     1165           
  Misses        224      224           
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkingsbury rkingsbury merged commit af29735 into main May 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnicodeDecodeError when importing pyEQL
1 participant