Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #475: get rid of in-browser tests #654

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Conversation

leplatrem
Copy link
Contributor

  • Since they have intermittent failures, we ignore their failures.
  • Their code coverage is really low
  • The tooling electron etc. is heavy to download/install

This is my solution to fix #475

@leplatrem leplatrem requested a review from glasserc October 5, 2018 07:22
Copy link
Contributor

@glasserc glasserc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm definitely OK with this.

@leplatrem leplatrem merged commit daca4bf into master Oct 5, 2018
@leplatrem leplatrem deleted the 475-remove-browser-tests branch October 5, 2018 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm run test-browser fails
2 participants