Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #265: Async Client #268

Merged
merged 7 commits into from
Nov 11, 2021
Merged

For #265: Async Client #268

merged 7 commits into from
Nov 11, 2021

Conversation

matt-boris
Copy link
Contributor

@matt-boris matt-boris commented Nov 4, 2021

For #265

  • Add Async Client (from kinto_http import AsyncClient)
  • Add Async Client tests
  • Keep 100% coverage
  • Update README.rst
  • Update CHANGELOG.rst
  • Update Makefile to ensure new tests run
  • Pull sync Client out of __init__.py file
  • Replace unittest with pytest

@matt-boris matt-boris force-pushed the matt-boris/asyncClient branch from c9fce25 to d46d4ad Compare November 5, 2021 13:56
@matt-boris matt-boris marked this pull request as ready for review November 8, 2021 21:43
@matt-boris
Copy link
Contributor Author

I'm going to replace unittest with pytest. Converting back to draft for now.

Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

I was thinking that we could have a test that would verify that the same methods are implemented in both clients, so that when we add a new method we don't forget to add it in both...

I left a few comments. If we plan to add support for the batch endpoint later, it would be better to create a follow-up issue to keep track that it's pending.

kinto_http/tests/config/kinto.ini Outdated Show resolved Hide resolved
kinto_http/client.py Outdated Show resolved Hide resolved
kinto_http/client.py Outdated Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
kinto_http/tests/test_async_client.py Outdated Show resolved Hide resolved
kinto_http/tests/conftest.py Outdated Show resolved Hide resolved
kinto_http/tests/test_functional_async.py Outdated Show resolved Hide resolved
kinto_http/tests/test_functional_async.py Outdated Show resolved Hide resolved
@leplatrem
Copy link
Contributor

We introduced backoff for the async client. I believe the sync client should obey the same behaviour. I would think that adding decorators there instead of on the async methods would be enough.

@matt-boris matt-boris requested a review from leplatrem November 10, 2021 19:50
Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@matt-boris matt-boris merged commit c5d705a into master Nov 11, 2021
@matt-boris matt-boris deleted the matt-boris/asyncClient branch November 11, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants