-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For #265: Async Client #268
Conversation
c9fce25
to
d46d4ad
Compare
I'm going to replace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
I was thinking that we could have a test that would verify that the same methods are implemented in both clients, so that when we add a new method we don't forget to add it in both...
I left a few comments. If we plan to add support for the batch endpoint later, it would be better to create a follow-up issue to keep track that it's pending.
We introduced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍
For #265
from kinto_http import AsyncClient
)README.rst
CHANGELOG.rst
Makefile
to ensure new tests run__init__.py
fileunittest
withpytest