Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Docker image build frozen step #3372

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix Docker image build frozen step #3372

merged 1 commit into from
Jan 30, 2024

Conversation

leplatrem
Copy link
Contributor

@leplatrem leplatrem commented Jan 29, 2024 •
edited
Loading

  • Use an intermediary folder instead of build on container's root folder /
  • Do not install as editable within the container
  • Explicitly list non .py as package data
  • Fix setuptools find package to include subpackages (kinto.core etc.)

@leplatrem leplatrem requested a review from alexcottner January 29, 2024 17:25
@leplatrem leplatrem added the bug label Jan 29, 2024
@leplatrem leplatrem force-pushed the fix-docker-build branch 3 times, most recently from 7157c84 to 06b4a9f Compare January 30, 2024 16:26
alexcottner
alexcottner approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@alexcottner alexcottner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the docker build issue for me

@leplatrem leplatrem merged commit 60fa847 into main Jan 30, 2024
15 checks passed
@leplatrem leplatrem deleted the fix-docker-build branch January 30, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcottner alexcottner alexcottner approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leplatrem @alexcottner