Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observe request summary, size, and duration with labels #3461

Merged
merged 8 commits into from
Nov 4, 2024

Conversation

leplatrem
Copy link
Contributor

Based on #3459

@ahoneiser Now that Kinto has Prometheus support, we can count things with more details. Do you have any suggestion?

@ahoneiser
Copy link

@leplatrem oh that's super nice, great work! From a perspective of determining that kinto is alive and well, __heartbeat__ and __lbheartbeat__ do a good job already.

Thinking about counting things, counting requests to individual buckets / collections / records would be a nice thing to have, e.g. to identify high volume resources and low volume resources, would help when doing housekeeping work (e.g. cleanups / maintenance), counts of requests / gauges of request sizes could also help us to put price tags to defined workloads (e.g. to be able to better answer questions like "how much would it cost to distribute resource x via kinto", or "how much cost do I produce when I require all clients to re-download resource x" etc.).

@leplatrem leplatrem force-pushed the request-summary-labels branch 2 times, most recently from 362e694 to 7c7ea92 Compare October 28, 2024 12:21
@leplatrem leplatrem changed the title Count request summary with labels Observe request summary, size, and duration with labels Oct 29, 2024
@leplatrem leplatrem marked this pull request as ready for review October 29, 2024 16:28
@leplatrem leplatrem requested a review from alexcottner October 29, 2024 16:28
@leplatrem
Copy link
Contributor Author

Related mozilla/remote-settings#691

@leplatrem leplatrem force-pushed the request-summary-labels branch 3 times, most recently from 28da5b6 to 3e7341a Compare November 4, 2024 17:36
@leplatrem leplatrem force-pushed the request-summary-labels branch from 3e7341a to 07c2d3d Compare November 4, 2024 18:09
@leplatrem leplatrem merged commit f2b80f0 into main Nov 4, 2024
16 checks passed
@leplatrem leplatrem deleted the request-summary-labels branch November 4, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants