Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3474: encode unsafe characters in request summary metric #3476

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Fix #3474: encode unsafe characters in request summary metric #3476

merged 2 commits into from
Dec 11, 2024

Conversation

leplatrem
Copy link
Contributor

Fix #3474

Two safety nets:

  • prevent weird characters to make it to our metrics inputs
  • prevent ':' to be put in Statsd metrics unique labels

@leplatrem leplatrem added the bug label Dec 10, 2024
@leplatrem
Copy link
Contributor Author

Merci @Natim ❤️

@leplatrem leplatrem merged commit bc66018 into main Dec 11, 2024
19 checks passed
@leplatrem leplatrem deleted the 3474-sanitize-statsd-metrics branch December 11, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Natim Natim Natim approved these changes

@alexcottner alexcottner Awaiting requested review from alexcottner

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sanitize endpoints strings before sending metrics to StatsD or Prometheus
2 participants
@leplatrem @Natim