Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2618: SQLite PCL replace #166

Merged
merged 3 commits into from
Oct 18, 2018

Conversation

heyzooi
Copy link
Contributor

@heyzooi heyzooi commented Sep 13, 2018

Description

Previous Nuget package SQLite.Net-PCL replaced by sqlite-net-pcl

PS: We need to wait until the PR below gets merged and released:

praeclarum/sqlite-net#752

Changes

  • Cache layer
  • Some adjustments for unit tests

Tests

  • Keep exactly the same to ensure the changes are working correctly

@heyzooi heyzooi self-assigned this Sep 13, 2018
.gitmodules Show resolved Hide resolved
Kinvey-Xamarin-Android/packages.config Show resolved Hide resolved
Kinvey-Xamarin-iOS/Client/IOSClientBuilder.cs Show resolved Hide resolved
Kinvey.Core/Store/DataStore.cs Show resolved Hide resolved
Kinvey.Core/Store/DataStore.cs Show resolved Hide resolved
Kinvey.Net/Client/DotnetClientBuilder.cs Show resolved Hide resolved
Kinvey/Kinvey.csproj Show resolved Hide resolved
TestFramework/TestSupportFiles/Address.cs Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Oct 2, 2018

Codecov Report

Merging #166 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #166      +/-   ##
===========================================
+ Coverage    80.34%   80.34%   +<.01%     
===========================================
  Files           85       85              
  Lines         7310     7265      -45     
===========================================
- Hits          5873     5837      -36     
+ Misses        1437     1428       -9
Flag Coverage Δ
#Linux 80.3% <100%> (ø) ⬆️
#Mono 77.34% <100%> (-0.01%) ⬇️
#macOS 80.3% <100%> (ø) ⬆️
Impacted Files Coverage Δ
Kinvey.Core/Offline/CollectionTableMap.cs 100% <ø> (ø) ⬆️
Kinvey.Core/Store/FindAggregateRequest.cs 97.91% <ø> (ø) ⬆️
Kinvey.Core/Offline/SQLTemplates.cs 0% <ø> (ø) ⬆️
Kinvey.Core/Model/Entity.cs 100% <ø> (ø) ⬆️
Kinvey.Core/Offline/QueryCacheItem.cs 100% <ø> (ø) ⬆️
Kinvey.Core/Auth/SQLCredential.cs 100% <ø> (ø) ⬆️
Kinvey.Net/Client/DotnetClientBuilder.cs 100% <ø> (ø) ⬆️
Kinvey.Core/Offline/PendingWriteAction.cs 83.33% <ø> (ø) ⬆️
Kinvey.Core/Offline/SQLiteSyncQueue.cs 82.09% <ø> (ø) ⬆️
Kinvey.Core/Model/KinveyMetaData.cs 100% <100%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0de3342...27088e4. Read the comment docs.

@heyzooi heyzooi merged commit 4fa5e70 into develop Oct 18, 2018
@heyzooi heyzooi deleted the feature/MLIBZ-2618-sqlite_lib_replace branch October 18, 2018 18:00
@heyzooi heyzooi restored the feature/MLIBZ-2618-sqlite_lib_replace branch October 18, 2018 18:02
@heyzooi heyzooi deleted the feature/MLIBZ-2618-sqlite_lib_replace branch October 18, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants