Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added full object support and translation for JavaScript & TypeScript targets #660

Conversation

ByteWolf-dev
Copy link
Contributor

@ByteWolf-dev ByteWolf-dev commented Jul 15, 2024

What type of change does this PR perform?

  • Info or documentation change (Non-breaking change that updates repo info files (e.g. README.md, CONTRIBUTING.md, etc.) or online documentation)
  • Website (Change that changes the design or functionality of the websites or docs)
  • Development or internal changes (These changes do not add new features or fix bugs, but update the code in other ways)
  • Bug fix (Non-breaking change which fixes an issue)
  • New feature (Non-breaking change which adds functionality)
  • Breaking change (Major bug fix or feature that would cause existing functionality not to work as expected.)
  • Requires a documentation update, as it changes language or compiler behaviour

Summary

Added the ability to use object literals.

Detailed Changelog

Not present for website/docs changes

Added

  • Added semantic checking and code generation for object literals and object properties. (#526)

Does this PR create new warnings?

None.

Linked issues or PRs

@ByteWolf-dev ByteWolf-dev linked an issue Jul 15, 2024 that may be closed by this pull request
4 tasks
@ByteWolf-dev ByteWolf-dev changed the title 526 feature add full object support and translation for jsts targets Added full object support and translation for jsts targets Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 70.45455% with 13 lines in your changes missing coverage. Please review.

Project coverage is 83.14%. Comparing base (ec3e373) to head (7d3d2e9).

Files Patch % Lines
kipper/target-js/src/code-generator.ts 40.00% 6 Missing ⚠️
...mary-expression/object-property/object-property.ts 64.28% 3 Missing and 2 partials ⚠️
...ct-primary-expression/object-primary-expression.ts 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           dev-next     #660      +/-   ##
============================================
+ Coverage     82.78%   83.14%   +0.35%     
============================================
  Files           265      265              
  Lines          4426     4461      +35     
  Branches        482      485       +3     
============================================
+ Hits           3664     3709      +45     
+ Misses          615      602      -13     
- Partials        147      150       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ByteWolf-dev ByteWolf-dev changed the base branch from main to dev-next July 15, 2024 11:05
@Luna-Klatzer Luna-Klatzer changed the title Added full object support and translation for jsts targets Added full object support and translation for JavaScript & TypeScript targets Jul 15, 2024
@Luna-Klatzer Luna-Klatzer added the feature New feature or enhancement label Jul 15, 2024
@Luna-Klatzer Luna-Klatzer added this to the v0.12.0 milestone Jul 15, 2024
@ByteWolf-dev ByteWolf-dev merged commit e3ad3e2 into dev-next Jul 16, 2024
24 of 25 checks passed
@ByteWolf-dev ByteWolf-dev deleted the 526-feature-add-full-object-support-and-translation-for-jsts-targets branch July 16, 2024 08:42
@Luna-Klatzer Luna-Klatzer mentioned this pull request Sep 18, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or enhancement
Projects
Development

Successfully merging this pull request may close these issues.

[Feature] Add full object support and translation for JS/TS targets
2 participants