Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for built-in constant NaN #676

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

Luna-Klatzer
Copy link
Member

What type of change does this PR perform?

  • Info or documentation change (Non-breaking change that updates repo info files (e.g. README.md, CONTRIBUTING.md, etc.) or online documentation)
  • Website (Change that changes the design or functionality of the websites or docs)
  • Development or internal changes (These changes do not add new features or fix bugs, but update the code in other ways)
  • Bug fix (Non-breaking change which fixes an issue)
  • New feature (Non-breaking change which adds functionality)
  • Breaking change (Major bug fix or feature that would cause existing functionality not to work as expected.)
  • Requires a documentation update, as it changes language or compiler behaviour

Summary

Added support for built-in support NaN, which simply represents NaN in the JavaScript and TypeScript target.

Closes #671

Detailed Changelog

Not present for website/docs changes

Added

  • Implemented constant NaN, which represents the NaN value in JavaScript (Not a Number). (#671)

Does this PR create new warnings?

None.

Linked issues or PRs

@Luna-Klatzer Luna-Klatzer added the feature New feature or enhancement label Jul 22, 2024
@Luna-Klatzer Luna-Klatzer added this to the v0.12.0 milestone Jul 22, 2024
@Luna-Klatzer Luna-Klatzer self-assigned this Jul 22, 2024
@Luna-Klatzer Luna-Klatzer linked an issue Jul 22, 2024 that may be closed by this pull request
3 tasks
@Luna-Klatzer Luna-Klatzer changed the base branch from main to dev-next July 22, 2024 10:07
@Luna-Klatzer Luna-Klatzer marked this pull request as ready for review July 22, 2024 10:07
…tant-nan

# Conflicts:
#	CHANGELOG.md
#	kipper/core/src/compiler/semantics/types/built-in/func.ts
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (9117107) to head (0c1b89d).

Additional details and impacted files
@@             Coverage Diff              @@
##           dev-next     #676      +/-   ##
============================================
+ Coverage     83.92%   83.98%   +0.05%     
============================================
  Files           270      270              
  Lines          4499     4502       +3     
  Branches        478      479       +1     
============================================
+ Hits           3776     3781       +5     
  Misses          582      582              
+ Partials        141      139       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Luna-Klatzer Luna-Klatzer merged commit 5e0ecc5 into dev-next Jul 22, 2024
25 checks passed
@Luna-Klatzer Luna-Klatzer deleted the 671-feature-add-built-in-constant-nan branch July 22, 2024 10:14
This was referenced Jul 22, 2024
@Luna-Klatzer Luna-Klatzer mentioned this pull request Sep 18, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or enhancement
Projects
Development

Successfully merging this pull request may close these issues.

[Feature] Add built-in constant NaN
1 participant