Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.12.1 #713

Merged
merged 6 commits into from
Feb 17, 2025
Merged

v0.12.1 #713

merged 6 commits into from
Feb 17, 2025

Conversation

Luna-Klatzer
Copy link
Member

@Luna-Klatzer Luna-Klatzer commented Feb 17, 2025

What type of change does this PR perform?

  • Info or documentation change (Non-breaking change that updates repo info files (e.g. README.md, CONTRIBUTING.md, etc.) or online documentation)
  • Website (Change that changes the design or functionality of the websites or docs)
  • Development or internal changes (These changes do not add new features or fix bugs, but update the code in other ways)
  • Bug fix (Non-breaking change which fixes an issue)
  • New feature (Non-breaking change which adds functionality)
  • Breaking change (Major bug fix or feature that would cause existing functionality not to work as expected.)
  • Requires a documentation update, as it changes language or compiler behaviour

Summary

New bug fix release 0.12.1, which fixes a bug in the duck-typing type check logic and a bug causing the PropertyNotFoundTypeError error to be thrown as a stand-alone error although it is an error indicating the failure of a parent type check operation.

Detailed Changelog

Not present for website/docs changes

Changed

  • Renamed:
    • Error MismatchingArgCountBetweenFuncTypesError to MismatchingArgCountBetweenFuncTypesTypeError.
    • Error UnknownTypeError to UnknownTypeTypeError.
    • Error PropertyNotFoundError to PropertyNotFoundTypeError.

Fixed

  • PropertyNotFoundTypeError being thrown as a stand-alone error instead of being set as the cause for any parent
    assignment operation failure.
  • PropertyNotFoundTypeError being checked for in the wrong direction i.e. that otherT had to have all the properties
    of thisT instead of the other way around (which is the correct way).
  • Indexable checks for str and Array<T> being accidentally turned off by incorrect logic. This caused
    ValueTypeNotIndexableWithGivenAccessorTypeError to be only thrown for objects and not for arrays and strings.

Does this PR create new warnings?

None.

Linked issues or PRs

No linked issues.

Due to a wrong direction of type checks, all properties of thisT had to be present in otherT (which isn't the concept of duck typing but strict ident typing)
…ed as the error cause for any failed parent assignment operation
…favor of a unified processing method `_processAnalysis`
@Luna-Klatzer Luna-Klatzer added release New release of the Kipper module. skip changelog Do not include in the changelog when a new release is drafted labels Feb 17, 2025
@Luna-Klatzer Luna-Klatzer requested a review from a team February 17, 2025 12:38
@Luna-Klatzer Luna-Klatzer self-assigned this Feb 17, 2025
@Luna-Klatzer Luna-Klatzer requested review from lorenzholzbauer and removed request for a team February 17, 2025 12:38
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 83.84%. Comparing base (e7e9ff9) to head (7b460d9).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...r/core/src/compiler/semantics/types/custom-type.ts 36.36% 6 Missing and 1 partial ⚠️
...re/src/compiler/semantics/analyser/type-checker.ts 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
- Coverage   83.85%   83.84%   -0.02%     
==========================================
  Files         283      283              
  Lines        4938     4932       -6     
  Branches      544      544              
==========================================
- Hits         4141     4135       -6     
+ Misses        651      650       -1     
- Partials      146      147       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Luna-Klatzer Luna-Klatzer changed the title Dev main v0.12.1 Feb 17, 2025
@Luna-Klatzer Luna-Klatzer merged commit dd6d30c into main Feb 17, 2025
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release New release of the Kipper module. skip changelog Do not include in the changelog when a new release is drafted
Projects
Development

Successfully merging this pull request may close these issues.

1 participant