Add Named Args to Tests; Bump to PHP 8.0+ #72
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds named arguments to tests for readability, which should help with reviewing future PRs that introduce the v4 API and changed parameter options.
Bumps minimum supported PHP version to 8.0 to support named arguments (8.1 and higher are officially supported by PHP, so likely we'll bump to 8.1 with the v4 API support: https://www.php.net/supported-versions.php). Users of 7.4 and lower can continue to use
1.3
of our SDK.Testing
Existing tests pass.
Checklist