Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Named Args to Tests; Bump to PHP 8.0+ #72

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

n7studios
Copy link
Contributor

Summary

Adds named arguments to tests for readability, which should help with reviewing future PRs that introduce the v4 API and changed parameter options.

Bumps minimum supported PHP version to 8.0 to support named arguments (8.1 and higher are officially supported by PHP, so likely we'll bump to 8.1 with the v4 API support: https://www.php.net/supported-versions.php). Users of 7.4 and lower can continue to use 1.3 of our SDK.

Testing

Existing tests pass.

Checklist

@n7studios n7studios self-assigned this Mar 15, 2024
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team March 15, 2024 14:07
@n7studios n7studios marked this pull request as ready for review March 15, 2024 14:07
Copy link

@noelherrick noelherrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. What's your general guideline for when you deprecate a PHP version? I checked 7.4 was EOL'd in 2022.

@n7studios
Copy link
Contributor Author

Makes sense. What's your general guideline for when you deprecate a PHP version? I checked 7.4 was EOL'd in 2022.

Typically deprecate ~ 1 year after its security fixes only have ended. There are some package statistics, but they get skewed when our unit tests run, so can't be accurately relied on.

@n7studios n7studios merged commit 14f0db3 into master Mar 18, 2024
4 checks passed
@n7studios n7studios deleted the tests-add-named-arguments branch June 26, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants