Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcasts: Don't display next import date/time when event running #586

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

n7studios
Copy link
Contributor

Summary

When the scheduled event to import ConvertKit Broadcasts to WordPress Posts is running, the timestamp for the next scheduled event is 1, resulting in incorrect output on the description:

Screenshot 2023-11-17 at 13 17 01

This PR resolves by not outputting the next scheduled date/time when the event is running:

Screenshot 2023-11-17 at 13 17 10

When the event is not running, the next scheduled date/time displays in the description.

Testing

  • BroadcastsToPostsCest:testBroadcastsManualImportWhenEnabled: Test that the description does not display when using the manual import functionality.

Checklist

@n7studios n7studios added the bug label Nov 17, 2023
@n7studios n7studios self-assigned this Nov 17, 2023
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team November 17, 2023 19:59
@n7studios n7studios marked this pull request as ready for review November 17, 2023 19:59
@n7studios n7studios merged commit 1547f49 into main Nov 20, 2023
62 checks passed
@n7studios n7studios deleted the fix-broadcasts-manual-import-description branch November 20, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants