Broadcasts Importer: Remove Duplicate Title in Content #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n7studios
changed the title
n7studios
requested review from
a team,
noelherrick and
jenessawhite
and removed request for
a team
noelherrick
approved these changes
Oct 31, 2024
n7studios
changed the base branch from
broadcasts-importer-refactor-functions
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As requested, if the Broadcast's title matches a H1 through H6 in the Broadcast's content, removes the heading in the content, because the Broadcast's title is always stored as the WordPress Post title, and a Post title is required.
Kit:
WordPress:
Testing
BroadcastsImportTest: Updated assertion to confirm no H1 is included in theHTML Template Testbroadcast, which contains the same title in both the Broadcast's title and H1.Checklist