Skip to content

Commit

Permalink
fix poor 1000ms wait UX
Browse files Browse the repository at this point in the history
  • Loading branch information
Irev-Dev committed Dec 17, 2024
1 parent 1e9cf6f commit e60cabb
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions src/clientSideScene/sceneEntities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1159,13 +1159,12 @@ export class SceneEntities {

// Update the primary AST and unequip the rectangle tool
await kclManager.executeAstMock(_ast)
sceneInfra.modelingSend({ type: 'Finish rectangle' })

// lee: I had this at the bottom of the function, but it's
// possible sketchFromKclValue "fails" when sketching on a face,
// and this couldn't wouldn't run.
await codeManager.updateEditorWithAstAndWriteToFile(_ast)

sceneInfra.modelingSend({ type: 'Finish rectangle' })
},
})
return { updatedEntryNodePath, updatedSketchNodePaths }
Expand Down Expand Up @@ -1350,13 +1349,12 @@ export class SceneEntities {

// Update the primary AST and unequip the rectangle tool
await kclManager.executeAstMock(_ast)
sceneInfra.modelingSend({ type: 'Finish center rectangle' })

// lee: I had this at the bottom of the function, but it's
// possible sketchFromKclValue "fails" when sketching on a face,
// and this couldn't wouldn't run.
await codeManager.updateEditorWithAstAndWriteToFile(_ast)

sceneInfra.modelingSend({ type: 'Finish center rectangle' })
}
},
})
Expand Down Expand Up @@ -1539,9 +1537,8 @@ export class SceneEntities {

// Update the primary AST and unequip the rectangle tool
await kclManager.executeAstMock(_ast)
await codeManager.updateEditorWithAstAndWriteToFile(_ast)

sceneInfra.modelingSend({ type: 'Finish circle' })
await codeManager.updateEditorWithAstAndWriteToFile(_ast)
}
},
})
Expand Down

0 comments on commit e60cabb

Please sign in to comment.