Bring back multi profile #4828

Irev-Dev · 2024-12-17T21:45:00Z

Revert revert.

closes #4828
closes #4619
closes #5191

This reverts commit efe8089.

vercel · 2024-12-17T21:45:05Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
modeling-app	✅ Ready (Inspect)	Visit Preview	Jan 10, 2025 8:50pm

qa-wolf · 2024-12-17T21:45:05Z

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Irev-Dev · 2024-12-17T22:56:25Z

src/lang/std/artifactGraph.ts

+/** {@deprecated} this information should come from the ArtifactGraph not digging around in the AST */
+function getWallOrCapPlaneCodeRef(


this is the dodgy thing @jtran that we can look to remove, it's used to get the codeRef for startSketchOn in the case of startSketchOn(extrude, faceTag), but we can remedy with more info returned from execution.

Add Rust side artifacts for startSketchOn face or plane #4834

Irev-Dev · 2024-12-17T23:02:05Z

@nadr0 e60cabb is where I "fix" the bad UX by changing the order such that the Xstate event is fired without waiting for the file write.

But ofc feel free to change if you think we can do better.

Irev-Dev · 2024-12-17T23:49:55Z

e2e test failures don't seem related.
And they were passing the first time this was merged.

* Add Rust side artifacts for startSketchOn face or plane * move ast digging --------- Co-authored-by: Kurt Hutten Irev-Dev <k.hutten@protonmail.ch>

…-8-cores)

…u-8-cores)

Irev-Dev · 2024-12-20T12:25:06Z

I resolved conflict (might have made mistake) but tests are still failing.

…u-8-cores)

pierremtb · 2024-12-20T16:11:53Z

Triggered CI after new snaps

codecov · 2024-12-20T18:04:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.84%. Comparing base (73a7e2b) to head (30397ba).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4828   +/-   ##
=======================================
  Coverage   85.84%   85.84%           
=======================================
  Files          88       88           
  Lines       31429    31432    +3     
=======================================
+ Hits        26981    26984    +3     
  Misses       4448     4448

Flag	Coverage Δ
wasm-lib	`85.84% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jtran · 2025-01-09T02:17:07Z

I just merged main and naively fixed merge conflicts. But there's a tsc error. Some new code needs to be updated.

I also blew away PNG snapshot changes that conflicted and used the ones from main. I figured we can let them be regenerated.

…u-8-cores)

lf94 · 2025-01-09T20:58:51Z

All tests are now passing; onto I guess just playing around a bit

lf94 · 2025-01-09T21:22:53Z

Ok, there are still some rough cases:

lf94 · 2025-01-09T21:31:21Z

2025-01-09_16-29-00.mp4

lf94 · 2025-01-10T16:46:04Z

Found another issue, doesn't highlight old sketch code:

2025-01-10_11-46-20.mp4

lf94 · 2025-01-10T16:48:30Z

Found another issue, it's selecting multiple sketches that do not belong to each other:

2025-01-10_11-49-01.mp4

jtran · 2025-01-12T18:28:42Z

src/components/ModelingMachineProvider.tsx

@@ -195,7 +195,7 @@ export const ModelingMachineProvider = ({
          store.videoElement?.pause()

          return kclManager
-            .executeCode()
+            .executeCode({ isPartialExecution: true })


With #5005, I think we determined this isn't partial execution.

Irev-Dev added 2 commits December 18, 2024 07:08

Revert "Revert multi-profile (#4812)"

1e9cf6f

This reverts commit efe8089.

fix poor 1000ms wait UX

e60cabb

vercel bot deployed to Preview December 17, 2024 21:56 View deployment

Merge remote-tracking branch 'origin' into kurt-bring-back-multi-profile

30edf2a

Irev-Dev commented Dec 17, 2024

View reviewed changes

A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores)

c696f08

trigger CI

2c40e8a

vercel bot deployed to Preview December 17, 2024 23:30 View deployment

jtran mentioned this pull request Dec 18, 2024

Add Rust side artifacts for startSketchOn face or plane #4834

Merged

Add Rust side artifacts for startSketchOn face or plane (#4834)

3865637

* Add Rust side artifacts for startSketchOn face or plane * move ast digging --------- Co-authored-by: Kurt Hutten Irev-Dev <k.hutten@protonmail.ch>

vercel bot deployed to Preview December 19, 2024 00:15 View deployment

pierremtb mentioned this pull request Dec 19, 2024

Cut release v0.33.0 #4836

Closed

Irev-Dev and others added 7 commits December 20, 2024 21:43

Merge remote-tracking branch 'origin' into kurt-bring-back-multi-profile

1b9f5f2

lint

9f93346

lint

e9086c5

A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-macos…

913f264

…-8-cores)

A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…

7197b6c

…u-8-cores)

A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-16-cores)

9f323c2

trigger CI

68c8974

vercel bot deployed to Preview December 20, 2024 11:36 View deployment

nadr0 and others added 2 commits December 20, 2024 23:21

chore: disabled file watcher which prevents faster file write (#4835)

6add1d7

A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…

0642e49

…u-8-cores)

Irev-Dev force-pushed the kurt-bring-back-multi-profile branch from bddf028 to 0642e49 Compare December 20, 2024 12:21

partial fixes

6c9d14a

A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…

b09c240

…u-8-cores)

vercel bot deployed to Preview December 20, 2024 12:55 View deployment

Trigger CI

2bb548c

vercel bot deployed to Preview December 20, 2024 16:23 View deployment

Merge branch 'main' into kurt-bring-back-multi-profile

d3e4b12

github-actions bot and others added 2 commits January 9, 2025 02:17

A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…

fcf3272

…u-8-cores)

Trigger CI

3344208

vercel bot deployed to Preview January 9, 2025 02:47 View deployment

lf94 self-assigned this Jan 9, 2025

Fix up all the tests

30397ba

vercel bot deployed to Preview January 9, 2025 21:10 View deployment

Fix partial execution

5fe3023

vercel bot deployed to Preview January 10, 2025 20:50 View deployment

jtran reviewed Jan 12, 2025

View reviewed changes

pierremtb linked an issue Jan 29, 2025 that may be closed by this pull request

Rework sketch mode to show all profiles and sketch geometry in AST that reference the current surface #2931

Open

jtran mentioned this pull request Jan 30, 2025

[BUG]: Can't sketch on face twice on the same face using point-and-click #5191

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bring back multi profile #4828

Bring back multi profile #4828

Irev-Dev commented Dec 17, 2024 •

edited by jessfraz

Loading

vercel bot commented Dec 17, 2024 •

edited

Loading

qa-wolf bot commented Dec 17, 2024

Irev-Dev Dec 17, 2024

jtran Dec 19, 2024

Irev-Dev commented Dec 17, 2024

Irev-Dev commented Dec 17, 2024 •

edited

Loading

Irev-Dev commented Dec 20, 2024

pierremtb commented Dec 20, 2024

codecov bot commented Dec 20, 2024 •

edited

Loading

jtran commented Jan 9, 2025 •

edited

Loading

lf94 commented Jan 9, 2025

lf94 commented Jan 9, 2025 •

edited

Loading

lf94 commented Jan 9, 2025

lf94 commented Jan 10, 2025

lf94 commented Jan 10, 2025

jtran Jan 12, 2025

		/** {@deprecated} this information should come from the ArtifactGraph not digging around in the AST */
		function getWallOrCapPlaneCodeRef(

Bring back multi profile #4828

Are you sure you want to change the base?

Bring back multi profile #4828

Conversation

Irev-Dev commented Dec 17, 2024 • edited by jessfraz Loading

vercel bot commented Dec 17, 2024 • edited Loading

qa-wolf bot commented Dec 17, 2024

Irev-Dev Dec 17, 2024

Choose a reason for hiding this comment

jtran Dec 19, 2024

Choose a reason for hiding this comment

Irev-Dev commented Dec 17, 2024

Irev-Dev commented Dec 17, 2024 • edited Loading

Irev-Dev commented Dec 20, 2024

pierremtb commented Dec 20, 2024

codecov bot commented Dec 20, 2024 • edited Loading

Codecov Report

jtran commented Jan 9, 2025 • edited Loading

lf94 commented Jan 9, 2025

lf94 commented Jan 9, 2025 • edited Loading

lf94 commented Jan 9, 2025

lf94 commented Jan 10, 2025

lf94 commented Jan 10, 2025

jtran Jan 12, 2025

Choose a reason for hiding this comment

Irev-Dev commented Dec 17, 2024 •

edited by jessfraz

Loading

vercel bot commented Dec 17, 2024 •

edited

Loading

Irev-Dev commented Dec 17, 2024 •

edited

Loading

codecov bot commented Dec 20, 2024 •

edited

Loading

jtran commented Jan 9, 2025 •

edited

Loading

lf94 commented Jan 9, 2025 •

edited

Loading