Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve vitest hang #1470

Merged
merged 5 commits into from
Feb 21, 2024
Merged

improve vitest hang #1470

merged 5 commits into from
Feb 21, 2024

Conversation

Irev-Dev
Copy link
Collaborator

@Irev-Dev Irev-Dev commented Feb 21, 2024

We have an ongoing intermittent and hard to track down issue with vitests hanging

I did not realise this seems to be somewhat common and hard to replicate for the vitest team
vitest-dev/vitest#2008

While the main fix was

import fetch from "node-fetch"

// @ts-ignore
globalThis.fetch = fetch

in our test setup

I've also upgraded vitest in the process.

Unfortunately these changes have also caused the code coverage to crash. I'm actually not worried about this because, we don't actually use the reports at all they just run. When I set them up the theory is that by running them with each PR I'll at least know when they break, so if we get to the point where we want to look at coverage reports we won't have to first debug why they don't run.
However I don't think we'll ever want these reports. Since we have run some of our tests with playwright due to the stream, the coverage reports don't actually reflect our test coverage and never will so it's garbage information. so I'm okay with loosing these.

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 21, 2024 2:22am

@Irev-Dev Irev-Dev force-pushed the kurt-improve-vitest-hang branch 2 times, most recently from ad692fe to 142eeba Compare February 21, 2024 01:49
@Irev-Dev Irev-Dev merged commit 0d88040 into main Feb 21, 2024
12 checks passed
@Irev-Dev Irev-Dev deleted the kurt-improve-vitest-hang branch February 21, 2024 02:23
@Irev-Dev Irev-Dev mentioned this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant