Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an ongoing intermittent and hard to track down issue with vitests hanging
I did not realise this seems to be somewhat common and hard to replicate for the vitest team
vitest-dev/vitest#2008
While the main fix was
in our test setup
I've also upgraded vitest in the process.
Unfortunately these changes have also caused the code coverage to crash. I'm actually not worried about this because, we don't actually use the reports at all they just run. When I set them up the theory is that by running them with each PR I'll at least know when they break, so if we get to the point where we want to look at coverage reports we won't have to first debug why they don't run.
However I don't think we'll ever want these reports. Since we have run some of our tests with playwright due to the stream, the coverage reports don't actually reflect our test coverage and never will so it's garbage information. so I'm okay with loosing these.